Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New module for managing volumes in Vexata storage arrays. (redo of PR #47091) #49006

Merged
merged 5 commits into from
Apr 10, 2019
Merged

New module for managing volumes in Vexata storage arrays. (redo of PR #47091) #49006

merged 5 commits into from
Apr 10, 2019

Conversation

vexata
Copy link
Contributor

@vexata vexata commented Nov 21, 2018

Initial commit for module to manage Vexata storage volumes + fixes from code review in pr #47091 that got messed up.

SUMMARY

Adding new module for managing volumes in Vexata storage arrays. + fixes from code review in pr #47091 that got messed up.

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

vexata_volume

ANSIBLE VERSION

ansible 2.8.0.dev0 (vexata_volume2 9629469) last updated 2018/11/21 13:32:48 (GMT -700)
config file = None
configured module search path = [u'/home/test/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
ansible python module location = /home/test/dev/ansible/lib/ansible
executable location = /home/test/dev/ansible/bin/ansible
python version = 2.7.15rc1 (default, Apr 15 2018, 21:51:34) [GCC 7.3.0]

ADDITIONAL INFORMATION

@vexata vexata mentioned this pull request Nov 21, 2018
Closed
@ansibot
Copy link
Contributor

ansibot commented Nov 21, 2018

Hi @vexata, thank you for submitting this pull-request!

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Nov 21, 2018

cc @acozine
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. new_contributor This PR is the first contribution by a new community member. new_module This PR includes a new module. new_plugin This PR includes a new plugin. storage support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Nov 21, 2018
@ansibot
Copy link
Contributor

ansibot commented Nov 21, 2018

The test ansible-test sanity --test pep8 [explain] failed with 2 errors:

lib/ansible/module_utils/vexata.py:73:28: E128 continuation line under-indented for visual indent
lib/ansible/module_utils/vexata.py:74:28: E128 continuation line under-indented for visual indent

click here for bot help

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. core_review In order to be merged, this PR must follow the core review workflow. needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. and removed core_review In order to be merged, this PR must follow the core review workflow. ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Nov 21, 2018
@vexata
Copy link
Contributor Author

vexata commented Nov 22, 2018 •
edited

@Akasurde messed up branch for my previous PR #47091, so I've submitted a new PR with the changes. Tests will be submitted in later PRs.

@Akasurde Akasurde removed the needs_triage Needs a first human triage before being processed. label Nov 22, 2018
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Nov 22, 2018
@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Mar 5, 2019
@vexata vexata closed this Mar 5, 2019
@vexata vexata reopened this Mar 5, 2019
@vexata
Copy link
Contributor Author

vexata commented Mar 8, 2019

@gundalow please let me know if this addresses everything:
d05f25f

@ansibot ansibot added stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. stale_review Updates were made after the last review and the last review is more than 7 days old. labels Mar 16, 2019
@vexata vexata closed this Mar 25, 2019
@vexata vexata reopened this Mar 25, 2019
@ansibot ansibot added stale_review Updates were made after the last review and the last review is more than 7 days old. and removed stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. stale_review Updates were made after the last review and the last review is more than 7 days old. labels Mar 25, 2019
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Apr 2, 2019
@vexata vexata closed this Apr 9, 2019
@vexata vexata reopened this Apr 9, 2019
@ansibot ansibot added stale_review Updates were made after the last review and the last review is more than 7 days old. and removed stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. stale_review Updates were made after the last review and the last review is more than 7 days old. labels Apr 9, 2019
@Akasurde
Copy link
Member

Closing and re-opening for CI trigger.

@Akasurde Akasurde closed this Apr 10, 2019
@Akasurde Akasurde reopened this Apr 10, 2019
@ansibot ansibot added stale_review Updates were made after the last review and the last review is more than 7 days old. and removed stale_review Updates were made after the last review and the last review is more than 7 days old. labels Apr 10, 2019
@Akasurde Akasurde merged commit e1c4ee2 into ansible:devel Apr 10, 2019
@vexata vexata deleted the vexata_volume2 branch April 10, 2019 19:38
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Akasurde Akasurde Akasurde approved these changes

@gundalow gundalow gundalow approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 docs This issue/PR relates to or includes documentation. docsite This issue/PR relates to the documentation website. module This issue/PR relates to a module. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. new_contributor This PR is the first contribution by a new community member. new_module This PR includes a new module. new_plugin This PR includes a new plugin. stale_review Updates were made after the last review and the last review is more than 7 days old. storage support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vexata @ansibot @Akasurde @gundalow