Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New module for managing volumes in Vexata storage arrays. #47091

Closed
wants to merge 893 commits into from
Closed

New module for managing volumes in Vexata storage arrays. #47091

wants to merge 893 commits into from

Conversation

vexata
Copy link
Contributor

@vexata vexata commented Oct 15, 2018

SUMMARY

Adding new module for managing volumes in Vexata storage arrays.

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

vexata_volume

ANSIBLE VERSION
  config file = /etc/ansible/ansible.cfg
  configured module search path = [u'/home/test/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /home/test/dev/ansible/lib/ansible
  executable location = /home/test/dev/ansible/bin/ansible
  python version = 2.7.6 (default, Nov 23 2017, 15:49:48) [GCC 4.8.4]
ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented Oct 15, 2018

Hi @vexata, thank you for submitting this pull-request!

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Oct 15, 2018

cc @acozine
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. new_contributor This PR is the first contribution by a new community member. new_module This PR includes a new module. new_plugin This PR includes a new plugin. storage support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Oct 15, 2018
@ryansb ryansb removed needs_triage Needs a first human triage before being processed. labels Oct 16, 2018
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Oct 25, 2018
@vexata vexata closed this Nov 5, 2018
@vexata vexata reopened this Nov 5, 2018
@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Nov 5, 2018
caphrim007 and others added 11 commits November 11, 2018 11:10
@caphrim007
Moving client variable out in bigiq modules (ansible#48542)
22c9da5 
This is being done to ensure that errors are not encountered if the
exception case is hit
@caphrim007
Removes the f5-sdk from bigip_selfip (ansible#48544)
708c2b4
@caphrim007
Removes the f5-sdk from bigip_routedomain (ansible#48543)
6233215
@dagwieers @jborean93
win_psexec: Rewrite using AnsibleModule (ansible#48383)
d174ebc
@dagwieers @jborean93
win_product_facts: Rewrite using AnsibleModule (ansible#48382)
2dd56eb
@dagwieers @jborean93
win_wakeonlan: Rewrite using AnsibleModule (ansible#48380)
baaa142
@caphrim007
Remove f5-sdk from bigip_vcmp_guest (ansible#48541)
5e7a02d
@dagwieers @jborean93
win_defrag: Rewrite using AnsibleModule (ansible#48381)
b312f7f 
* win_defrag: Rewrite using AnsibleModule

* Fix delta return value
@dagwieers @jborean93
win_tempfile: Rewrite using AnsibleModule (ansible#48386)
ab8125f 
* win_tempfile: Rewrite using AnsibleModule

* Fix up error check

* Fix PSParameterizedProperty issue
@caphrim007
Workaround for problems parsing the timezone (ansible#48549)
92b2d01 
Device facts gets a time with a timezone back from the builddate.
Unfortunately, python cannot correctly parse timezones by default.
This hacks around the problem.
@idahood @trishnaguha
Fix LLDP to use json (ansible#48318)
e51964e
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Nov 21, 2018
bcoca and others added 10 commits November 21, 2018 11:51
@bcoca
ignore netapp tests when no libs (ansible#48941)
9115042 
* ignore tests when no libs
@Tomorrow9 @ansibot
Fix pr44962 add check before hot add cpu or memory (ansible#48289)
9b44109
@gundalow
Validate DOCUMENTATION.author (ansible#48993)
75407d3 
* Validate DOCUMENTATION.author

Ensure that author line includes a GitHub account
@vexata
Initial commit for Vexata volume module.
06ef0b8
@vexata
Change Ansible version to 2.8
acef6b4
@vexata
Fix lint and sanity errors reported by tests.
180928e
@Akasurde @vexata
Update lib/ansible/module_utils/vexata.py
6e02263 
Co-Authored-By: vexata <python-dev@vexata.com>
@Akasurde @vexata
Update lib/ansible/modules/storage/vexata/vexata_volume.py
26cce29 
Co-Authored-By: vexata <python-dev@vexata.com>
@Akasurde @vexata
Update lib/ansible/modules/storage/vexata/vexata_volume.py
d49f5f0 
Co-Authored-By: vexata <python-dev@vexata.com>
@Akasurde @vexata
Update lib/ansible/modules/storage/vexata/vexata_volume.py
a1481a7 
Co-Authored-By: vexata <python-dev@vexata.com>
@ansibot
Copy link
Contributor

ansibot commented Nov 21, 2018

The test ansible-test sanity --test compile --python 2.6 [explain] failed with 1 error:

lib/ansible/module_utils/vexata.py:84:9: SyntaxError: ...

The test ansible-test sanity --test compile --python 2.7 [explain] failed with 1 error:

lib/ansible/module_utils/vexata.py:84:9: SyntaxError: ...

The test ansible-test sanity --test import --python 2.6 [explain] failed with 2 errors:

lib/ansible/module_utils/vexata.py:84:9: SyntaxError: invalid syntax
lib/ansible/modules/storage/vexata/vexata_volume.py:74:0: SyntaxError: invalid syntax (vexata.py, line 84)

The test ansible-test sanity --test import --python 2.7 [explain] failed with 2 errors:

lib/ansible/module_utils/vexata.py:84:9: SyntaxError: invalid syntax
lib/ansible/modules/storage/vexata/vexata_volume.py:74:0: SyntaxError: invalid syntax (vexata.py, line 84)

click here for bot help

@ansibot ansibot added the ci_verified Changes made in this PR are causing tests to fail. label Nov 21, 2018
@ansibot
Copy link
Contributor

ansibot commented Nov 21, 2018

@vexata this PR contains the following merge commits:

Please rebase your branch to remove these commits.

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Nov 21, 2018

@vexata This PR contains @ mentions in at least one commit message. Those mentions can cause cascading notifications through GitHub and need to be removed. Please squash or amend your commits to remove the mentions.

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Nov 21, 2018

@vexata This PR was evaluated as a potentially problematic PR for the following reasons:

  • More than 50 changed files.
  • More than 50 commits.

Such PR can only be merged by human. Contact a Core team member to review this PR on IRC: #ansible-devel on irc.freenode.net

click here for bot help

@ansibot ansibot added merge_commit This PR contains at least one merge commit. Please resolve! needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html and removed ci_verified Changes made in this PR are causing tests to fail. labels Nov 21, 2018
vexata added a commit to vexata/ansible that referenced this pull request Nov 21, 2018
@vexata
Initial commit for module to manage Vexata storage volumes + fixes fo…
9629469 
…rm code review in pr ansible#47091.
@vexata vexata mentioned this pull request Nov 21, 2018
Merged
@vexata
Copy link
Contributor Author

vexata commented Nov 21, 2018

Messed up this PR, closing it and opened PR 49006 with the changes

@vexata vexata closed this Nov 21, 2018
vexata added a commit to vexata/ansible that referenced this pull request Mar 5, 2019
@vexata
Initial commit for module to manage Vexata storage volumes + fixes fo…
b6fd186 
…rm code review in pr ansible#47091.
StephenSorriaux pushed a commit to StephenSorriaux/ansible that referenced this pull request Apr 10, 2019
@vexata @Akasurde
New module for managing volumes in Vexata storage arrays (ansible#49006)
e1c4ee2 
* Initial commit for module to manage Vexata storage volumes + fixes form code review in pr ansible#47091.

* Fix indent errors reported by lint.

* Refactor, implement code review changes

* Moved doc fragment file to new layout

* Added explicit types for all module parameters, updated copyrights + raw string for block text.
@vexata vexata deleted the vexata_volume branch April 10, 2019 19:44
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Akasurde Akasurde Akasurde requested changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 docs This issue/PR relates to or includes documentation. merge_commit This PR contains at least one merge commit. Please resolve! module This issue/PR relates to a module. needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. new_contributor This PR is the first contribution by a new community member. new_module This PR includes a new module. new_plugin This PR includes a new plugin. storage support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet