Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add launch type to ecs task #49081

Merged
merged 8 commits into from
Mar 6, 2019
Merged

Add launch type to ecs task #49081

merged 8 commits into from
Mar 6, 2019

Conversation

ezmac
Copy link
Contributor

@ezmac ezmac commented Nov 23, 2018

SUMMARY

Adds launch_type support to ecs_task

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

ecs_task

ADDITIONAL INFORMATION

Requires a little more permission in the ecs trust policy.

@ansibot
Copy link
Contributor

ansibot commented Nov 23, 2018

Hi @ezmac, thank you for submitting this pull-request!

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Nov 23, 2018

cc @Java1Guy @willthames
click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Nov 23, 2018

@ezmac, just so you are aware we have a dedicated Working Group for aws.
You can find other people interested in this in #ansible-aws on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 aws cloud community_review In order to be merged, this PR must follow the community review workflow. feature This issue/PR relates to a feature request. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. new_contributor This PR is the first contribution by a new community member. support:community This issue/PR relates to code supported by the Ansible community. and removed new_contributor This PR is the first contribution by a new community member. labels Nov 23, 2018
@gundalow gundalow removed needs_triage Needs a first human triage before being processed. labels Nov 28, 2018
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Dec 6, 2018
@ezmac ezmac closed this Dec 7, 2018
@ezmac ezmac reopened this Dec 7, 2018
@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Dec 7, 2018
@ansibot ansibot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Dec 23, 2018
@ezmac ezmac closed this Jan 2, 2019
@ezmac ezmac reopened this Jan 2, 2019
@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jan 2, 2019
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Feb 16, 2019
@ansibot
Copy link
Contributor

ansibot commented Feb 21, 2019

The test ansible-test sanity --test changelog [explain] failed with 1 error:

changelogs/fragments/49081-add-launch-type-to-ecs-task.yml:0:0: invalid section: minor_change

click here for bot help

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Feb 21, 2019
@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Feb 21, 2019
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Mar 1, 2019
@willthames
Copy link
Contributor

This looks good to me - I'll run the test suite over it later and get this merged if all goes well.

@willthames willthames mentioned this pull request Mar 6, 2019
Closed
@willthames
Copy link
Contributor

I've added a trivial patch to this to allow ecs:StopTask and ecs:StartTask

rebuild_merge

@ansibot ansibot added shipit This PR is ready to be merged by Core support:core This issue/PR relates to code supported by the Ansible Engineering Team. and removed community_review In order to be merged, this PR must follow the community review workflow. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Mar 6, 2019
@willthames
Copy link
Contributor

bot_status

@ansibot
Copy link
Contributor

ansibot commented Mar 6, 2019

Components

changelogs/fragments/49081-add-launch-type-to-ecs-task.yml
support: community
maintainers:

changelogs/fragments/ecs_task_fargate.yml
support: community
maintainers:

hacking/aws_config/testing_policies/container-policy.json
support: core
maintainers:

lib/ansible/modules/cloud/amazon/ecs_task.py
support: community
maintainers: Java1Guy willthames

test/integration/targets/ecs_cluster/playbooks/roles/ecs_cluster/files/ecs-trust-policy.json
support: community
maintainers: Java1Guy willthames

test/integration/targets/ecs_cluster/playbooks/roles/ecs_cluster/tasks/main.yml
support: community
maintainers: Java1Guy willthames

Metadata

waiting_on: ansible
changes_requested_by: null
needs_info: False
needs_revision: False
needs_rebase: False
merge_commits: []
too many files or commits: False
mergeable_state: unstable
shippable_status: None
maintainer_shipits (module maintainers): 0
community_shipits (namespace maintainers): 0
ansible_shipits (core team members): 0
shipit_actors (maintainer or core team member): []
shipit_actors_other: []
automerge: automerge shipit test failed

click here for bot help

@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. and removed shipit This PR is ready to be merged by Core labels Mar 6, 2019
@willthames
Copy link
Contributor

force push was just to remove an unnecessary commit I made adding a secondary changelog fragment that was already there.

@willthames willthames merged commit b979b26 into ansible:devel Mar 6, 2019
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 aws cloud core_review In order to be merged, this PR must follow the core review workflow. feature This issue/PR relates to a feature request. module This issue/PR relates to a module. needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ezmac @ansibot @willthames @gundalow