Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New module to support BGP configuration management in IOS #49121

Merged
merged 20 commits into from
Mar 4, 2019
Merged

New module to support BGP configuration management in IOS #49121

merged 20 commits into from
Mar 4, 2019

Conversation

NilashishC
Copy link
Contributor

@NilashishC NilashishC commented Nov 26, 2018 •
edited

SUMMARY
  • Added new module - ios_bgp
  • This module provides configuration management of global BGP parameters
    on devices running Cisco IOS
  • Targets this.
ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

ios_bgp.py

ANSIBLE VERSION
devel

@NilashishC NilashishC changed the title WIP: New module - ios_bgp WIP: New module to support BGP configuration management in IOS Nov 26, 2018
@ansibot
Copy link
Contributor

ansibot commented Nov 26, 2018

Hi @NilashishC, thank you for submitting this pull-request!

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Nov 26, 2018

cc @Qalthos @ganeshrn @gdpak @justjais @rcarrillocruz @trishnaguha
click here for bot help

@ansibot ansibot added WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. affects_2.8 This issue/PR affects Ansible v2.8 module This issue/PR relates to a module. needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. needs_triage Needs a first human triage before being processed. networking Network category new_module This PR includes a new module. new_plugin This PR includes a new plugin. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. support:network This issue/PR relates to code supported by the Ansible Network Team. test This PR relates to tests. labels Nov 26, 2018
@NilashishC NilashishC removed the new_plugin This PR includes a new plugin. label Nov 26, 2018
@ansibot ansibot removed needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Nov 26, 2018
@NilashishC

This comment has been minimized.

Sign in to view
@ansibot

This comment has been minimized.

Sign in to view
@ansibot ansibot added the ci_verified Changes made in this PR are causing tests to fail. label Nov 26, 2018
@ansibot ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label Dec 3, 2018
@ansibot

This comment has been minimized.

Sign in to view
@ansibot

This comment has been minimized.

Sign in to view
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Dec 11, 2018
@abenokraitis abenokraitis added this to Needs Triage in Networking via automation Jan 22, 2019
@abenokraitis abenokraitis added this to the 2.8.0 milestone Jan 22, 2019
@abenokraitis
Copy link
Contributor

cc @cidrblock

@dagwieers dagwieers added the cisco Cisco technologies label Feb 22, 2019
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. core_review In order to be merged, this PR must follow the core review workflow. and removed core_review In order to be merged, this PR must follow the core review workflow. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Feb 26, 2019
@NilashishC
ios_bgp initial push
9bc3d90 
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
@NilashishC
Added tests for ios_bgp
1a4a32c 
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
@NilashishC
Fixed docs
0668116 
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
@NilashishC
Added space
fbd7e7f 
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
@NilashishC
Fix Shippable Errors
2725a33 
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
@NilashishC
Fix Shippable Errors
09c1c29 
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
@NilashishC
Add support for af_neighbor option
3b85c5a 
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
@NilashishC
Add support for af_neighbor option - 2
2fe98d3 
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
@NilashishC
Add support for af_neighbor option - 3
9c635e2 
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
@NilashishC
Fix typo
740677c 
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
@NilashishC
Refactor BGP
26ac760 
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
@NilashishC
Fix CI and previous reviews
b2006c7 
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
@NilashishC
Add missing params documentation
995c375 
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
@NilashishC
Remove previous tests
1c037c2 
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
@NilashishC
Remove elements=dict from keys with type=list from args spec for elem…
9ea53fd 
…ent validation to pass

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
@NilashishC
Added function to validate input
03ed437 
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
@NilashishC
Fix sanity test failure
0b2a041 
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
@NilashishC
Minor bug fixes
58538a1 
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
@NilashishC
Fix typo in fixture
3d77336 
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
@NilashishC
Add integration tests
f9d7f17 
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
@NilashishC NilashishC merged commit 55bfa18 into ansible:devel Mar 4, 2019
Networking automation moved this from Review to Done Mar 4, 2019
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ganeshrn ganeshrn ganeshrn approved these changes

@samccann samccann samccann approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 cisco Cisco technologies core_review In order to be merged, this PR must follow the core review workflow. ios Cisco IOS community module This issue/PR relates to a module. networking Network category new_module This PR includes a new module. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. support:network This issue/PR relates to code supported by the Ansible Network Team. test This PR relates to tests.
Projects
No open projects
Networking
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@NilashishC @ansibot @abenokraitis @ganeshrn @samccann @dagwieers