Fix iosxr netconf plugin response namespace #49238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* iosxr netconf plugin removes namespace by default for all the responses as parsing of xml is easier without namepsace in iosxr module. However to validate the response received from device against yang model requires namespace to be present in resposne. * Add a parameter in iosxr netconf plugin to control if namespace should be removed from response or not.
|
Hi @ganeshrn, thank you for submitting this pull-request! |
ansibot
added
affects_2.8
ganeshrn
removed
the
needs_triage
|
The test |
ansibot
added
ci_verified
ansibot
added
core_review
gdpak
suggested changes
Nov 28, 2018
| @@ -389,7 +392,10 @@ def get_oper(module, filter=None): | |||
|
|
|||
| if filter is not None: | |||
| try: | |||
| response = conn.get(filter) | |||
| if is_netconf(module): | |||
| response = conn.get(filter, remove_ns=True) | |||
There was a problem hiding this comment.
There is existing bug in this code. iosxr netconf connection plugin's 'get' method does not have any non-keyword argument. so here probably passing a keyword arg might not work.
'conn.get(filter=filter, remove_ns=True)'
There was a problem hiding this comment.
The issue is fixed on devel, however, I will change as you suggested since same iosxr plugin will be copied in yang role that is currently dependent on 2.7 Ansible version.
| @@ -436,7 +442,7 @@ def load_config(module, command_filter, commit=False, replace=False, | |||
|
|
|||
| try: | |||
| for filter in to_list(command_filter): | |||
| conn.edit_config(filter) | |||
| conn.edit_config(filter, remove_ns=True) | |||
There was a problem hiding this comment.
Same here. below should work
- conn.edit_config(filter)
+ conn.edit_config(config=filter, remove_ns=True)
| @@ -125,56 +125,80 @@ def guess_network_os(obj): | |||
|
|
|||
| # TODO: change .xml to .data_xml, when ncclient supports data_xml on all platforms | |||
| @ensure_connected | |||
| def get(self, filter=None): | |||
| def get(self, filter=None, remove_ns=False): | |||
There was a problem hiding this comment.
I am not sure of history but why do we need remove_ns at first place ? is it for conversion to json ?
There was a problem hiding this comment.
iirc this logic was added to iosxr plugin so that parsing of XML response string using lxml library in the iosxr declarative modules is easier. If the namespace is present in the XML string the XPath traversal in declarative modules requires adding nested namespaces to traversal logic thus making it complex.
ansibot
added
needs_revision
gdpak
approved these changes
Nov 29, 2018
ansibot
added
core_review
|
@gdpak Thank you for review. |
ganeshrn
added a commit
to ganeshrn/ansible
that referenced
this pull request
Nov 29, 2018
* Fix iosxr netconf plugin response namespace * iosxr netconf plugin removes namespace by default for all the responses as parsing of xml is easier without namepsace in iosxr module. However to validate the response received from device against yang model requires namespace to be present in resposne. * Add a parameter in iosxr netconf plugin to control if namespace should be removed from response or not. * Fix CI issues * Fix review comment (cherry picked from commit 829fc0f)
abadger
pushed a commit
that referenced
this pull request
Dec 4, 2018
* Fix iosxr netconf plugin response namespace * iosxr netconf plugin removes namespace by default for all the responses as parsing of xml is easier without namepsace in iosxr module. However to validate the response received from device against yang model requires namespace to be present in resposne. * Add a parameter in iosxr netconf plugin to control if namespace should be removed from response or not. * Fix CI issues * Fix review comment (cherry picked from commit 829fc0f)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
for all the responses as parsing of xml is easier without namespace in iosxr module. However, to
validate the response received from the device against yang model requires namespace to be
present.
should be removed from the response or not.
ISSUE TYPE
COMPONENT NAME
netconf/iosxr.py
ADDITIONAL INFORMATION