Fix iosxr netconf plugin response namespace (#49238) #49300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix iosxr netconf plugin response namespace * iosxr netconf plugin removes namespace by default for all the responses as parsing of xml is easier without namepsace in iosxr module. However to validate the response received from device against yang model requires namespace to be present in resposne. * Add a parameter in iosxr netconf plugin to control if namespace should be removed from response or not. * Fix CI issues * Fix review comment (cherry picked from commit 829fc0f)
ganeshrn
force-pushed
the
backport/2.7/49238
branch
from
3cfe8a7
to
7e02fc1
Compare
|
Hi @ganeshrn, thank you for submitting this pull-request! |
ansibot
added
affects_2.7
|
Merged for the 2.7.5 release. |
sivel
removed
the
needs_triage
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fix iosxr netconf plugin response namespace
iosxr netconf plugin removes namespace by default
for all the responses as parsing of xml is easier without namespace in iosxr module. However, to validate the response received from device against yang model requires namespace to be present in the response.
Add a parameter in iosxr netconf plugin to control if the namespace
should be removed from the response or not.
Fix CI issues
Fix review comment
Merged to devel #49238
(cherry picked from commit 829fc0f)
ISSUE TYPE
COMPONENT NAME
netconf/iosxr.py
ADDITIONAL INFORMATION