Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add path info to role list #49346

Merged
merged 3 commits into from
Dec 10, 2018
Merged

add path info to role list #49346

merged 3 commits into from
Dec 10, 2018

Conversation

bcoca
Copy link
Member

@bcoca bcoca commented Nov 30, 2018 •
edited

  • use same display format for both listing all and specific roles
  • show warnings at end to allow selecting the output w/o interruption
ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

ansible-galaxy

ADDITIONAL INFORMATION

Before:

- test1, (unknown version)
 [WARNING]: - the configured path /usr/share/ansible/roles does not exist.

- geerlingguy.apache, 2.0.0
- test-1, (unknown version)
- test2, (unknown version)
- test1, (unknown version)

After:

# /home/bcoca/.ansible/roles
- test1, (unknown version)
# /etc/ansible/roles
- geerlingguy.apache, 2.0.0
- test-1, (unknown version)
- test2, (unknown version)
- test1, (unknown version)
 [WARNING]: - the configured path /usr/share/ansible/roles does not exist.

@bcoca
add path info to role list
c865163 
 - use same display format for both listing all and specific roles
@bcoca
just dirname
87dd024
@ansibot
Copy link
Contributor

ansibot commented Nov 30, 2018

Hi @bcoca, thank you for submitting this pull-request!

click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 core_review In order to be merged, this PR must follow the core review workflow. feature This issue/PR relates to a feature request. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Nov 30, 2018
Akasurde
Akasurde reviewed Nov 30, 2018
View reviewed changes
lib/ansible/cli/galaxy.py Outdated Show resolved Hide resolved
@Akasurde @bcoca
Update lib/ansible/cli/galaxy.py
808551f 
Co-Authored-By: bcoca <bcoca@users.noreply.github.com>
@bcoca
Copy link
Member Author

bcoca commented Dec 1, 2018

ready_for_review

@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Dec 1, 2018
@sivel sivel removed needs_triage Needs a first human triage before being processed. labels Dec 4, 2018
@bcoca bcoca merged commit 42a13d1 into ansible:devel Dec 10, 2018
@bcoca bcoca deleted the nicer_role_list branch December 10, 2018 16:41
kbreit pushed a commit to kbreit/ansible that referenced this pull request Jan 11, 2019
@bcoca @kbreit
add path info to role list (ansible#49346)
f8b99a8 
* add path info to role list

 - use same display format for both listing all and specific roles


Co-Authored-By: bcoca <bcoca@users.noreply.github.com>
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Akasurde Akasurde Akasurde left review comments

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 core_review In order to be merged, this PR must follow the core review workflow. feature This issue/PR relates to a feature request. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bcoca @ansibot @Akasurde @sivel