Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

simplify vm_guest detection code #49378

Merged
merged 1 commit into from
Dec 10, 2018
Merged

simplify vm_guest detection code #49378

merged 1 commit into from
Dec 10, 2018

Conversation

bcoca
Copy link
Member

@bcoca bcoca commented Nov 30, 2018

  • remove a lot of repetition
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

fact gathering

@ansibot
Copy link
Contributor

ansibot commented Nov 30, 2018

Hi @bcoca, thank you for submitting this pull-request!

click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Nov 30, 2018
@bcoca
simplify vm_guest detection code
8fd40d8 
  - remove a lot of repetition
  - change lists to tuples since they are faster to assign
@ansible ansible deleted a comment from ansibot Nov 30, 2018
@bcoca bcoca removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Nov 30, 2018
@ansibot ansibot added the core_review In order to be merged, this PR must follow the core review workflow. label Nov 30, 2018
@samdoran samdoran removed the needs_triage Needs a first human triage before being processed. label Dec 4, 2018
@bcoca bcoca merged commit e53a785 into ansible:devel Dec 10, 2018
@bcoca bcoca deleted the simpler_vm_guest_detect branch December 10, 2018 16:42
kbreit pushed a commit to kbreit/ansible that referenced this pull request Jan 11, 2019
@bcoca @kbreit
simplify vm_guest detection code (ansible#49378)
7727614 
- remove a lot of repetition
  - change lists to tuples since they are faster to assign
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bcoca @ansibot @samdoran