Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azure_rm_image: fix creation of image with data disks #49394

Merged
merged 1 commit into from
Dec 5, 2018
Merged

azure_rm_image: fix creation of image with data disks #49394

merged 1 commit into from
Dec 5, 2018

Conversation

jeking3
Copy link
Contributor

@jeking3 jeking3 commented Nov 30, 2018

SUMMARY

Creation of images with data disks would always fail, as the lun parameter to ImageDataDisk must be named.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

azure_rm_image

ADDITIONAL INFORMATION
bash-4.4# ansible --version
ansible 2.8.0.dev0 (azure-image-lun-fix dbf5887937) last updated 2018/11/30 22:13:33 (GMT +000)
  config file = None
  configured module search path = [u'/root/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /ansible/lib/ansible
  executable location = /ansible/bin/ansible
  python version = 2.7.15 (default, Sep 12 2018, 02:38:23) [GCC 6.4.0]

@jeking3 jeking3 mentioned this pull request Nov 30, 2018
Merged
@ansibot
Copy link
Contributor

ansibot commented Nov 30, 2018

Hi @jeking3, thank you for submitting this pull-request!

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Nov 30, 2018

cc @haroldwongms @nitzmahone @trstringer @xscript @yuwzho @zikalino
click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Nov 30, 2018

@jeking3, just so you are aware we have a dedicated Working Group for azure.
You can find other people interested in this in #ansible-azure on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 azure bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. small_patch support:community This issue/PR relates to code supported by the Ansible community. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Nov 30, 2018
@ansibleazurebot ansibleazurebot mentioned this pull request Dec 1, 2018
Closed
@Fred-sun
Copy link
Contributor

Fred-sun commented Dec 3, 2018

@jeking3 Thanks for your contribution, When you finished and ready for review, I will test the feature and push to review. Thanks!

@jeking3
Copy link
Contributor Author

jeking3 commented Dec 3, 2018

This is ready. Without this change, the call fails.

@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Dec 3, 2018
@Fred-sun
Copy link
Contributor

Fred-sun commented Dec 4, 2018 •
edited

@yuwzho @yungezz @zikalino ready_for_review

@yuwzho
Copy link
Contributor

yuwzho commented Dec 4, 2018

shipit

@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Dec 4, 2018
@jeking3
Copy link
Contributor Author

jeking3 commented Dec 4, 2018

I have updated the integration test to make an image with a data disk. This was missing, and likely the reason the issue went unnoticed.

@jeking3
Copy link
Contributor Author

jeking3 commented Dec 4, 2018

FYI I have a more comprehensive update for this module coming soon, which allows for specification of all the OS and data disk parameters (caching, storage account type, lun, etc..) - now that I know how to update and run the integration test, that PR will include test changes too.

@yungezz yungezz merged commit 79c0e30 into ansible:devel Dec 5, 2018
@yungezz
Copy link
Contributor

yungezz commented Dec 5, 2018

does this need to be backported to stable-2.7 branch? @yuwzho

@yuwzho
Copy link
Contributor

yuwzho commented Dec 5, 2018

yes, I will backport it

yuwzho pushed a commit to VSChina/ansible that referenced this pull request Dec 5, 2018
@jeking3 @yuwzho
azure_rm_image: fix creation of image with data disks (ansible#49394)
c868b83 
(cherry picked from commit 79c0e30)
abadger pushed a commit that referenced this pull request Dec 5, 2018
@yuwzho @abadger
azure_rm_image: fix creation of image with data disks (#49394) (#49518)
bc80087 
* azure_rm_image: fix creation of image with data disks (#49394)

(cherry picked from commit 79c0e30)

* Create 49394_azure_image.yml
@jeking3 jeking3 deleted the azure-image-lun-fix branch December 5, 2018 19:30
kbreit pushed a commit to kbreit/ansible that referenced this pull request Jan 11, 2019
@jeking3 @kbreit
azure_rm_image: fix creation of image with data disks (ansible#49394)
b049b67
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yuwzho yuwzho yuwzho approved these changes

@yungezz yungezz yungezz approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 azure bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. small_patch support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jeking3 @ansibot @Fred-sun @yuwzho @yungezz