Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New parameters and bugfixes for na_ontap_volume #49511

Merged
merged 3 commits into from
Feb 19, 2019
Merged

New parameters and bugfixes for na_ontap_volume #49511

merged 3 commits into from
Feb 19, 2019

Conversation

carchi8py
Copy link
Contributor

SUMMARY

New parameters and bugfixes for na_ontap_volume

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME
  • na_ontap_volume
ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented Dec 4, 2018

cc @amit0701 @hulquest @lmprice @lonico @ndswartz @schmots1
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 core_review In order to be merged, this PR must follow the core review workflow. feature This issue/PR relates to a feature request. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. netapp storage support:certified This issue/PR relates to certified code. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Dec 4, 2018
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. and removed core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. labels Dec 10, 2018
@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jan 7, 2019
@ansibot
Copy link
Contributor

ansibot commented Jan 10, 2019

@carchi8py this PR contains the following merge commits:

Please rebase your branch to remove these commits.

click here for bot help

@ansibot ansibot added merge_commit This PR contains at least one merge commit. Please resolve! needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html and removed merge_commit This PR contains at least one merge commit. Please resolve! needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html labels Jan 10, 2019
@ansibot ansibot added stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. stale_review Updates were made after the last review and the last review is more than 7 days old. labels Jan 22, 2019
beeankha
beeankha approved these changes Jan 28, 2019
View reviewed changes
Copy link
Contributor

@beeankha beeankha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All tests passed locally. 👍

@ansibot ansibot removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. stale_review Updates were made after the last review and the last review is more than 7 days old. labels Feb 6, 2019
@ansibot ansibot added the core_review In order to be merged, this PR must follow the core review workflow. label Feb 6, 2019
@carchi8py carchi8py mentioned this pull request Feb 6, 2019
Closed
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Feb 14, 2019
@carchi8py
Copy link
Contributor Author

@gundalow is there anything else we need to do to have this one merged in?

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Feb 15, 2019
lonico
lonico approved these changes Feb 15, 2019
View reviewed changes
Copy link
Contributor

@lonico lonico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Feb 17, 2019
@gundalow gundalow merged commit c62a698 into ansible:devel Feb 19, 2019
@gundalow
Copy link
Contributor

Feature merged into devel for release in Ansible 2.8. Thanks!

@lonico
Copy link
Contributor

lonico commented May 30, 2019

close #51790

@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@thedoubl3j thedoubl3j thedoubl3j left review comments

@gundalow gundalow gundalow approved these changes

@lonico lonico lonico approved these changes

@beeankha beeankha beeankha approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 feature This issue/PR relates to a feature request. module This issue/PR relates to a module. netapp shipit This PR is ready to be merged by Core storage support:certified This issue/PR relates to certified code. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@carchi8py @ansibot @gundalow @lonico @thedoubl3j @beeankha