Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override path to shutdown command in reboot module #49712

Closed
gforster opened this issue Dec 10, 2018 · 6 comments · Fixed by #50353
Closed

Override path to shutdown command in reboot module #49712

gforster opened this issue Dec 10, 2018 · 6 comments · Fixed by #50353
Labels
affects_2.8 This issue/PR affects Ansible v2.8 aix AIX community feature This issue/PR relates to a feature request. module This issue/PR relates to a module. support:core This issue/PR relates to code supported by the Ansible Engineering Team.

Comments

@gforster
Copy link
Contributor

gforster commented Dec 10, 2018

SUMMARY

Could use the ability to pass a custom path to override the default one.

ISSUE TYPE
  • Feature Idea
COMPONENT NAME

reboot

ADDITIONAL INFORMATION

In my specific case, I call a wrapper script that does some other sanity checks on process owned by a different team before determining it is safe to shutdown, then calling the reboot command. Or, for OSes that haven't yet been accounted for in the code.

@ansibot

This comment has been minimized.

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 feature This issue/PR relates to a feature request. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Dec 10, 2018
@ansibot

This comment has been minimized.

@ansibot
Copy link
Contributor

ansibot commented Dec 10, 2018

@ansibot ansibot added the module This issue/PR relates to a module. label Dec 10, 2018
@samdoran
Copy link
Contributor

samdoran commented Dec 11, 2018

The ability to change the shutdown command was omitted by design. Given how the shutdown command argument is constructed, it would be somewhat difficult (but not insurmountable) to add this as a parameter to the module.

Could you accomplish the same thing with a script task before the reboot task using a conditional to control whether or not the reboot task is run? If the script exists on the remote, it could be command or shell task.

needs_info

@ansibot ansibot added needs_info This issue requires further information. Please answer any outstanding questions. and removed needs_triage Needs a first human triage before being processed. labels Dec 11, 2018
@gforster
Copy link
Contributor Author

Makes sense. I suppose that is a valid point. Will need to add AIX support for this - I’ll work on a patch for that

Sent with GitHawk

@ansibot ansibot added needs_triage Needs a first human triage before being processed. and removed needs_info This issue requires further information. Please answer any outstanding questions. labels Dec 11, 2018
@samdoran
Copy link
Contributor

@gforster I'd love to add AIX support. Can you reach out to me on IRC in #ansible-devel or sdoran directly so I can get the necessary information from you? Or I can help you with the PR.

I just merged a good bit of changes this morning (c1589c3) that should make it far simpler to add new platforms.

@samdoran samdoran removed the needs_triage Needs a first human triage before being processed. label Dec 11, 2018
@ansibot ansibot added the needs_triage Needs a first human triage before being processed. label Dec 11, 2018
@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Dec 11, 2018
@dagwieers dagwieers added the aix AIX community label Jan 8, 2019
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.8 This issue/PR affects Ansible v2.8 aix AIX community feature This issue/PR relates to a feature request. module This issue/PR relates to a module. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants