docker_container always reports changed when using network_mode: container:<name>

[bengerman13]

SUMMARY

when using docker_container, if you set network_mode with a container:name, it always reports changed

ISSUE TYPE

• Bug Report

COMPONENT NAME

docker_container

ANSIBLE VERSION

ansible 2.7.1
  config file = None
  configured module search path = ['/home/benb/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = /home/benb/.local/share/virtualenvs/ansible-platform-pnaOgkJy/lib/python3.7/site-packages/ansible
  executable location = /home/benb/.local/share/virtualenvs/ansible-platform-pnaOgkJy/bin/ansible
  python version = 3.7.0 (default, Sep 12 2018, 18:30:08) [GCC 8.0.1 20180414 (experimental) [trunk revision 259383]]

CONFIGURATION

$ ansible-config dump --only-changed
$ 

OS / ENVIRONMENT

Host and guest are Ubuntu 18.04

STEPS TO REPRODUCE

- name: Start telegraf sidecar container
  docker_container:
    name: telegraf_1
    image: telegraf
    network_mode: container:other_container

- name: Do it again
  docker_container:
    name: telegraf_1
    image: telegraf
    network_mode: container:other_container

EXPECTED RESULTS

Do it again should not report changed

ACTUAL RESULTS

        "changed": true,
        "diff": {
            "differences": [
                {
                    "network_mode": {
                        "container": "container:ef16e4f7a9f868fa0b0c409eb46b13a685174ce6c1f87878e8955283aab1516d",
                        "parameter": "container:other_container"
                    }
                }
            ]
        }

[ansibot]

Files identified in the description:

• lib/ansible/modules/cloud/docker/docker_container.py

If these files are inaccurate, please update the component name section of the description or use the !component bot command.

click here for bot help

[ansibot]

cc @DBendit @akshay196 @chouseknecht @cove @danihodovic @dariko @dusdanig @felixfontein @joshuaconner @jwitko @kassiansun @softzilla @tbouvet @zfil
click here for bot help

[felixfontein]

This has been fixed in #47997; it is contained both in Ansible 2.7.2 and 2.6.x (don't ask me from which X on, though :) ).

[DBendit]

No, this is definitely still happening. I just wrote up some integ tests to verify it and I'm seeing the reported functionality in 2.8. While pid_mode and ipc_mode have their container names replaced, network_mode doesn't.

[bengerman13]

@felixfontein this is still happening for me with 2.7.2

ansible 2.7.2
  config file = None
  configured module search path = ['/home/benb/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = /home/benb/.local/share/virtualenvs/ansible-platform-pnaOgkJy/lib/python3.7/site-packages/ansible
  executable location = /home/benb/.local/share/virtualenvs/ansible-platform-pnaOgkJy/bin/ansible
  python version = 3.7.0 (default, Sep 12 2018, 18:30:08) [GCC 8.0.1 20180414 (experimental) [trunk revision 259383]]

[felixfontein]

Ah, I guess I misread that, then. Sorry!

[resmo]

reopening on requests.

[DBendit]

Guess the bot really wants this closed.

Regardless, I've already got a fix in PR. I'll backport it to 2.7 once it's merged in, though it won't be released until 2.7.6, since 2.7.5 is already locked down.

[bengerman13]

Thank you, @DBendit