Checkpoint host #49936

rcarrillocruz · 2018-12-14T11:29:19Z

SUMMARY

Checkpoint host

ISSUE TYPE

New Module Pull Request

COMPONENT NAME

checkpoint_host

ansibot · 2018-12-14T11:32:08Z

cc @NilashishC @Qalthos @ganeshrn @gdpak @justjais @trishnaguha
click here for bot help

ansibot · 2018-12-14T13:08:51Z

The test ansible-test sanity --test pylint [explain] failed with 1 error:

lib/ansible/modules/network/checkpoint/checkpoint_host.py:93:12: unnecessary-pass Unnecessary pass statement

The test ansible-test sanity --test ansible-doc --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/network/checkpoint/checkpoint_host.py:0:0: missing documentation (or could not parse documentation): Parsing produced an empty object.

The test ansible-test sanity --test ansible-doc --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/network/checkpoint/checkpoint_host.py:0:0: missing documentation (or could not parse documentation): Parsing produced an empty object.

The test ansible-test sanity --test ansible-doc --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/network/checkpoint/checkpoint_host.py:0:0: missing documentation (or could not parse documentation): Parsing produced an empty object.

The test ansible-test sanity --test ansible-doc --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/network/checkpoint/checkpoint_host.py:0:0: missing documentation (or could not parse documentation): Parsing produced an empty object.

The test ansible-test sanity --test ansible-doc --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/network/checkpoint/checkpoint_host.py:0:0: missing documentation (or could not parse documentation): Parsing produced an empty object.

The test ansible-test sanity --test docs-build [explain] failed with the error:

Command "/usr/bin/python test/sanity/code-smell/docs-build.py" returned exit status 1.
>>> Standard Error
Command 'make singlehtmldocs' failed with status code: 2
--> Standard Output
cat _themes/srtd/static/css/theme.css | sed -e 's/^[ 	]*//g; s/[ 	]*$//g; s/\([:{;,]\) /\1/g; s/ {/{/g; s/\/\*.*\*\///g; /^$/d' | sed -e :a -e '$!N; s/\n\(.\)/\1/; ta' > _themes/srtd/static/css/theme.min.css
PYTHONPATH=../../lib ../bin/dump_config.py --template-file=../templates/config.rst.j2 --output-dir=rst/reference_appendices/ -d ../../lib/ansible/config/base.yml
mkdir -p rst/cli
PYTHONPATH=../../lib ../bin/generate_man.py --template-file=../templates/cli_rst.j2 --output-dir=rst/cli/ --output-format rst ../../lib/ansible/cli/*.py
PYTHONPATH=../../lib ../bin/dump_keywords.py --template-dir=../templates --output-dir=rst/reference_appendices/ -d ./keyword_desc.yml
PYTHONPATH=../../lib ../bin/plugin_formatter.py -t rst --template-dir=../templates --module-dir=../../lib/ansible/modules -o rst/modules/ 
Makefile:93: recipe for target 'modules' failed
--> Standard Error
Traceback (most recent call last):
  File "../bin/plugin_formatter.py", line 723, in <module>
    main()
  File "../bin/plugin_formatter.py", line 681, in main
    plugin_info, categories = get_plugin_info(options.module_dir, limit_to=options.limit_to, verbose=(options.verbosity > 0))
  File "../bin/plugin_formatter.py", line 296, in get_plugin_info
    if 'options' in doc and doc['options'] is None:
TypeError: argument of type 'NoneType' is not iterable
make: *** [modules] Error 1

The test ansible-test sanity --test boilerplate [explain] failed with 2 errors:

lib/ansible/modules/network/checkpoint/checkpoint_host.py:0:0: missing: __metaclass__ = type
lib/ansible/modules/network/checkpoint/checkpoint_host.py:0:0: missing: from __future__ import (absolute_import, division, print_function)

The test ansible-test sanity --test pep8 [explain] failed with 10 errors:

lib/ansible/module_utils/network/checkpoint/checkpoint.py:29:1: E302 expected 2 blank lines, found 1
lib/ansible/module_utils/network/checkpoint/checkpoint.py:32:1: E302 expected 2 blank lines, found 1
lib/ansible/modules/network/checkpoint/checkpoint_host.py:18:1: E302 expected 2 blank lines, found 1
lib/ansible/modules/network/checkpoint/checkpoint_host.py:29:1: E302 expected 2 blank lines, found 1
lib/ansible/modules/network/checkpoint/checkpoint_host.py:40:1: E302 expected 2 blank lines, found 1
lib/ansible/modules/network/checkpoint/checkpoint_host.py:45:15: E124 closing bracket does not match visual indentation
lib/ansible/modules/network/checkpoint/checkpoint_host.py:51:1: E302 expected 2 blank lines, found 1
lib/ansible/modules/network/checkpoint/checkpoint_host.py:54:7: E271 multiple spaces after keyword
lib/ansible/modules/network/checkpoint/checkpoint_host.py:58:1: E302 expected 2 blank lines, found 1
lib/ansible/modules/network/checkpoint/checkpoint_host.py:98:1: E305 expected 2 blank lines after class or function definition, found 0

click here for bot help

ansibot · 2018-12-14T16:12:49Z

The test ansible-test sanity --test ansible-doc --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/network/checkpoint/checkpoint_host.py:0:0: missing documentation (or could not parse documentation): Parsing produced an empty object.

The test ansible-test sanity --test ansible-doc --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/network/checkpoint/checkpoint_host.py:0:0: missing documentation (or could not parse documentation): Parsing produced an empty object.

The test ansible-test sanity --test ansible-doc --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/network/checkpoint/checkpoint_host.py:0:0: missing documentation (or could not parse documentation): Parsing produced an empty object.

The test ansible-test sanity --test ansible-doc --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/network/checkpoint/checkpoint_host.py:0:0: missing documentation (or could not parse documentation): Parsing produced an empty object.

The test ansible-test sanity --test ansible-doc --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/network/checkpoint/checkpoint_host.py:0:0: missing documentation (or could not parse documentation): Parsing produced an empty object.

The test ansible-test sanity --test docs-build [explain] failed with the error:

Command "/usr/bin/python test/sanity/code-smell/docs-build.py" returned exit status 1.
>>> Standard Error
Command 'make singlehtmldocs' failed with status code: 2
--> Standard Output
cat _themes/srtd/static/css/theme.css | sed -e 's/^[ 	]*//g; s/[ 	]*$//g; s/\([:{;,]\) /\1/g; s/ {/{/g; s/\/\*.*\*\///g; /^$/d' | sed -e :a -e '$!N; s/\n\(.\)/\1/; ta' > _themes/srtd/static/css/theme.min.css
PYTHONPATH=../../lib ../bin/dump_config.py --template-file=../templates/config.rst.j2 --output-dir=rst/reference_appendices/ -d ../../lib/ansible/config/base.yml
mkdir -p rst/cli
PYTHONPATH=../../lib ../bin/generate_man.py --template-file=../templates/cli_rst.j2 --output-dir=rst/cli/ --output-format rst ../../lib/ansible/cli/*.py
PYTHONPATH=../../lib ../bin/dump_keywords.py --template-dir=../templates --output-dir=rst/reference_appendices/ -d ./keyword_desc.yml
PYTHONPATH=../../lib ../bin/plugin_formatter.py -t rst --template-dir=../templates --module-dir=../../lib/ansible/modules -o rst/modules/ 
Makefile:93: recipe for target 'modules' failed
--> Standard Error
Traceback (most recent call last):
  File "../bin/plugin_formatter.py", line 723, in <module>
    main()
  File "../bin/plugin_formatter.py", line 681, in main
    plugin_info, categories = get_plugin_info(options.module_dir, limit_to=options.limit_to, verbose=(options.verbosity > 0))
  File "../bin/plugin_formatter.py", line 296, in get_plugin_info
    if 'options' in doc and doc['options'] is None:
TypeError: argument of type 'NoneType' is not iterable
make: *** [modules] Error 1

The test ansible-test sanity --test pep8 [explain] failed with 2 errors:

lib/ansible/module_utils/network/checkpoint/checkpoint.py:29:1: E302 expected 2 blank lines, found 1
lib/ansible/module_utils/network/checkpoint/checkpoint.py:32:1: E302 expected 2 blank lines, found 1

click here for bot help

ansibot · 2018-12-19T08:31:18Z

The test ansible-test sanity --test ansible-doc --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/network/checkpoint/checkpoint_host.py:0:0: missing documentation (or could not parse documentation): Parsing produced an empty object.

The test ansible-test sanity --test ansible-doc --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/network/checkpoint/checkpoint_host.py:0:0: missing documentation (or could not parse documentation): Parsing produced an empty object.

The test ansible-test sanity --test ansible-doc --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/network/checkpoint/checkpoint_host.py:0:0: missing documentation (or could not parse documentation): Parsing produced an empty object.

The test ansible-test sanity --test ansible-doc --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/network/checkpoint/checkpoint_host.py:0:0: missing documentation (or could not parse documentation): Parsing produced an empty object.

The test ansible-test sanity --test ansible-doc --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/network/checkpoint/checkpoint_host.py:0:0: missing documentation (or could not parse documentation): Parsing produced an empty object.

The test ansible-test sanity --test docs-build [explain] failed with the error:

Command "/usr/bin/python test/sanity/code-smell/docs-build.py" returned exit status 1.
>>> Standard Error
Command 'make singlehtmldocs' failed with status code: 2
--> Standard Output
cat _themes/srtd/static/css/theme.css | sed -e 's/^[ 	]*//g; s/[ 	]*$//g; s/\([:{;,]\) /\1/g; s/ {/{/g; s/\/\*.*\*\///g; /^$/d' | sed -e :a -e '$!N; s/\n\(.\)/\1/; ta' > _themes/srtd/static/css/theme.min.css
PYTHONPATH=../../lib ../bin/dump_config.py --template-file=../templates/config.rst.j2 --output-dir=rst/reference_appendices/ -d ../../lib/ansible/config/base.yml
mkdir -p rst/cli
PYTHONPATH=../../lib ../bin/generate_man.py --template-file=../templates/cli_rst.j2 --output-dir=rst/cli/ --output-format rst ../../lib/ansible/cli/*.py
PYTHONPATH=../../lib ../bin/dump_keywords.py --template-dir=../templates --output-dir=rst/reference_appendices/ -d ./keyword_desc.yml
PYTHONPATH=../../lib ../bin/plugin_formatter.py -t rst --template-dir=../templates --module-dir=../../lib/ansible/modules -o rst/modules/ 
Evaluating module files...
Makefile:93: recipe for target 'modules' failed
--> Standard Error
Traceback (most recent call last):
  File "../bin/plugin_formatter.py", line 749, in <module>
    main()
  File "../bin/plugin_formatter.py", line 704, in main
    plugin_info, categories = get_plugin_info(options.module_dir, limit_to=options.limit_to, verbose=(options.verbosity > 0))
  File "../bin/plugin_formatter.py", line 316, in get_plugin_info
    if 'options' in doc and doc['options'] is None:
TypeError: argument of type 'NoneType' is not iterable
make: *** [modules] Error 1

The test ansible-test sanity --test pep8 [explain] failed with 2 errors:

lib/ansible/module_utils/network/checkpoint/checkpoint.py:29:1: E302 expected 2 blank lines, found 1
lib/ansible/module_utils/network/checkpoint/checkpoint.py:32:1: E302 expected 2 blank lines, found 1

click here for bot help

ansibot · 2018-12-19T13:16:50Z

The test ansible-test sanity --test ansible-doc --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/network/checkpoint/checkpoint_host.py:0:0: missing documentation (or could not parse documentation): Parsing produced an empty object.

The test ansible-test sanity --test ansible-doc --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/network/checkpoint/checkpoint_host.py:0:0: missing documentation (or could not parse documentation): Parsing produced an empty object.

The test ansible-test sanity --test ansible-doc --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/network/checkpoint/checkpoint_host.py:0:0: missing documentation (or could not parse documentation): Parsing produced an empty object.

The test ansible-test sanity --test ansible-doc --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/network/checkpoint/checkpoint_host.py:0:0: missing documentation (or could not parse documentation): Parsing produced an empty object.

The test ansible-test sanity --test ansible-doc --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/network/checkpoint/checkpoint_host.py:0:0: missing documentation (or could not parse documentation): Parsing produced an empty object.

The test ansible-test sanity --test docs-build [explain] failed with the error:

Command "/usr/bin/python test/sanity/code-smell/docs-build.py" returned exit status 1.
>>> Standard Error
Command 'make singlehtmldocs' failed with status code: 2
--> Standard Output
cat _themes/srtd/static/css/theme.css | sed -e 's/^[ 	]*//g; s/[ 	]*$//g; s/\([:{;,]\) /\1/g; s/ {/{/g; s/\/\*.*\*\///g; /^$/d' | sed -e :a -e '$!N; s/\n\(.\)/\1/; ta' > _themes/srtd/static/css/theme.min.css
PYTHONPATH=../../lib ../bin/dump_config.py --template-file=../templates/config.rst.j2 --output-dir=rst/reference_appendices/ -d ../../lib/ansible/config/base.yml
mkdir -p rst/cli
PYTHONPATH=../../lib ../bin/generate_man.py --template-file=../templates/cli_rst.j2 --output-dir=rst/cli/ --output-format rst ../../lib/ansible/cli/*.py
PYTHONPATH=../../lib ../bin/dump_keywords.py --template-dir=../templates --output-dir=rst/reference_appendices/ -d ./keyword_desc.yml
PYTHONPATH=../../lib ../bin/plugin_formatter.py -t rst --template-dir=../templates --module-dir=../../lib/ansible/modules -o rst/modules/ 
Evaluating module files...
Makefile:93: recipe for target 'modules' failed
--> Standard Error
Traceback (most recent call last):
  File "../bin/plugin_formatter.py", line 749, in <module>
    main()
  File "../bin/plugin_formatter.py", line 704, in main
    plugin_info, categories = get_plugin_info(options.module_dir, limit_to=options.limit_to, verbose=(options.verbosity > 0))
  File "../bin/plugin_formatter.py", line 316, in get_plugin_info
    if 'options' in doc and doc['options'] is None:
TypeError: argument of type 'NoneType' is not iterable
make: *** [modules] Error 1

The test ansible-test sanity --test import --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/network/checkpoint/checkpoint_host.py:8:0: ImportError: No module named checkpoint.checkpoint

The test ansible-test sanity --test import --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/network/checkpoint/checkpoint_host.py:8:0: ImportError: No module named 'ansible.module_utils.network.checkpoint'

The test ansible-test sanity --test import --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/network/checkpoint/checkpoint_host.py:8:0: ModuleNotFoundError: No module named 'ansible.module_utils.network.checkpoint'

The test ansible-test sanity --test import --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/network/checkpoint/checkpoint_host.py:8:0: ImportError: No module named checkpoint.checkpoint

The test ansible-test sanity --test import --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/network/checkpoint/checkpoint_host.py:8:0: ModuleNotFoundError: No module named 'ansible.module_utils.network.checkpoint'

click here for bot help

ansibot · 2019-01-09T11:37:45Z

The test ansible-test sanity --test validate-modules [explain] failed with 2 errors:

lib/ansible/modules/network/checkpoint/checkpoint_host.py:0:0: E322 "state" is listed in the argument_spec, but not documented in the module
lib/ansible/modules/network/checkpoint/checkpoint_host.py:0:0: E324 Value for "default" from the argument_spec ('present') for "state" does not match the documentation (None)

click here for bot help

samccann

some minor doc suggestions.

samccann · 2019-01-09T18:45:37Z

lib/ansible/modules/network/checkpoint/checkpoint_host.py

+module: checkpoint_host
+short_description: Manages host objects on Checkpoint over Web Services API
+description:
+  - Manages host objects on Checkpoint devices including creating, updating, removing access rules objects,


Suggested change

- Manages host objects on Checkpoint devices including creating, updating, removing access rules objects,

- Manages host objects on Checkpoint devices including creating, updating, removing access rules objects.

samccann · 2019-01-09T18:46:35Z

lib/ansible/modules/network/checkpoint/checkpoint_host.py

+  ip_address:
+    description:
+      - IP address of the host object.
+    type: str


Is it applicable to be clear whether this is IPv4 or IPv6? can it handle both? or would users of this module already know that?

* Add checkpoint_host module * Add state param to docstring * Require ip_address if state is present * Make else more explicit by doing and elif 404 * Remove bogus paren * Add checkpoint_host module

ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Dec 14, 2018

mattclay added the ci_verified Changes made in this PR are causing tests to fail. label Dec 19, 2018

ansibot removed needs_triage Needs a first human triage before being processed. ci_verified Changes made in this PR are causing tests to fail. labels Dec 19, 2018

mattclay added the ci_verified Changes made in this PR are causing tests to fail. label Dec 19, 2018

ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Dec 27, 2018

abenokraitis assigned rcarrillocruz Jan 8, 2019

abenokraitis added this to Needs Triage in Networking via automation Jan 8, 2019

ansibot added the needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html label Jan 8, 2019

rcarrillocruz force-pushed the checkpoint_host branch from 56613ca to bae79f7 Compare January 9, 2019 11:28

Add checkpoint_host module

19e608e

rcarrillocruz force-pushed the checkpoint_host branch from bae79f7 to 19e608e Compare January 9, 2019 11:29

ansibot removed needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Jan 9, 2019

ansibot removed the support:network This issue/PR relates to code supported by the Ansible Network Team. label Jan 9, 2019

rcarrillocruz added 4 commits January 9, 2019 12:37

Add state param to docstring

e69db48

Require ip_address if state is present

bc0d311

Make else more explicit by doing and elif 404

c53b912

Remove bogus paren

acc6675

ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jan 9, 2019

Add checkpoint_host module

8bfa9e1

samccann reviewed Jan 9, 2019

View reviewed changes

Qalthos approved these changes Jan 9, 2019

View reviewed changes

rcarrillocruz merged commit 88eb01b into ansible:devel Jan 10, 2019

Networking automation moved this from Needs Triage to Done Jan 10, 2019

ansible locked and limited conversation to collaborators Jul 22, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Checkpoint host #49936

Checkpoint host #49936

rcarrillocruz commented Dec 14, 2018

ansibot commented Dec 14, 2018

ansibot commented Dec 14, 2018

ansibot commented Dec 14, 2018

ansibot commented Dec 19, 2018

ansibot commented Dec 19, 2018

ansibot commented Jan 9, 2019

samccann left a comment

samccann Jan 9, 2019

samccann Jan 9, 2019

	- Manages host objects on Checkpoint devices including creating, updating, removing access rules objects,
	- Manages host objects on Checkpoint devices including creating, updating, removing access rules objects.

Checkpoint host #49936

Checkpoint host #49936

Conversation

rcarrillocruz commented Dec 14, 2018

SUMMARY

ISSUE TYPE

COMPONENT NAME

ansibot commented Dec 14, 2018

ansibot commented Dec 14, 2018

ansibot commented Dec 14, 2018

ansibot commented Dec 19, 2018

ansibot commented Dec 19, 2018

ansibot commented Jan 9, 2019

samccann left a comment

Choose a reason for hiding this comment

samccann Jan 9, 2019

Choose a reason for hiding this comment

samccann Jan 9, 2019

Choose a reason for hiding this comment