Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vmware_guest: improve task error handling #49960

Merged
merged 1 commit into from
Jan 21, 2019
Merged

vmware_guest: improve task error handling #49960

merged 1 commit into from
Jan 21, 2019

Conversation

jeking3
Copy link
Contributor

@jeking3 jeking3 commented Dec 14, 2018

SUMMARY

Many code paths in vmware_guest ignored the resulting task state. If the task ended in error the module did not fail. Also cleaned up a few minor flake8 issues.

Fixes #48281

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

vmware_guest

@ansibot
Copy link
Contributor

ansibot commented Dec 14, 2018

cc @Akasurde @ckotte @dav1x @nerzhul @pdellaert @warthog9
click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Dec 14, 2018

@jeking3, just so you are aware we have a dedicated Working Group for vmware.
You can find other people interested in this in #ansible-vmware on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. vmware VMware community labels Dec 14, 2018
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Dec 24, 2018
@jeking3
Copy link
Contributor Author

jeking3 commented Jan 17, 2019

Please merge?

pdellaert
pdellaert approved these changes Jan 17, 2019
View reviewed changes
Copy link
Contributor

@pdellaert pdellaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Jan 17, 2019
@Akasurde Akasurde mentioned this pull request Jan 21, 2019
Closed
@Akasurde Akasurde merged commit 9b3e74f into ansible:devel Jan 21, 2019
@Akasurde
Copy link
Member

@jeking3 Thanks for the contribution and @pdellaert Thanks for the review.

@jeking3 jeking3 deleted the vmware-guest-task-error-handling branch January 21, 2019 13:46
knumskull pushed a commit to knumskull/ansible that referenced this pull request Jan 21, 2019
@jeking3 @knumskull
vmware_guest: improve task error handling (ansible#49960)
87b3997
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pdellaert pdellaert pdellaert approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:community This issue/PR relates to code supported by the Ansible community. vmware VMware community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

vmware_guest does not check for errors in many code paths
4 participants
@jeking3 @ansibot @Akasurde @pdellaert