Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed an issue with parameter breaking idempotency #50117

Merged
merged 2 commits into from
Dec 19, 2018
Merged

fixed an issue with parameter breaking idempotency #50117

merged 2 commits into from
Dec 19, 2018

Conversation

wojtek0806
Copy link
Contributor

SUMMARY

Fixed issue with fqdn_auto_populate parameter breaking idempotency

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

bigip_pool_member

ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented Dec 18, 2018

cc @caphrim007
click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Dec 18, 2018

@wojtek0806, just so you are aware we have a dedicated Working Group for network.
You can find other people interested in this in #ansible-network on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. committer_review In order to be merged, this PR must follow the certified review workflow. f5 module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category new_contributor This PR is the first contribution by a new community member. support:certified This issue/PR relates to certified code. labels Dec 18, 2018
@ansibot
Copy link
Contributor

ansibot commented Dec 19, 2018

The test ansible-test sanity --test validate-modules [explain] failed with 3 errors:

lib/ansible/modules/network/f5/bigip_pool_member.py:0:0: E319 RETURN.address.type: not a valid value for dictionary value @ data['address']['type']. Got 'string'
lib/ansible/modules/network/f5/bigip_pool_member.py:0:0: E319 RETURN.description.type: not a valid value for dictionary value @ data['description']['type']. Got 'string'
lib/ansible/modules/network/f5/bigip_pool_member.py:0:0: E319 RETURN.fqdn.type: not a valid value for dictionary value @ data['fqdn']['type']. Got 'string'

click here for bot help

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed committer_review In order to be merged, this PR must follow the certified review workflow. labels Dec 19, 2018
@caphrim007 caphrim007 removed the needs_triage Needs a first human triage before being processed. label Dec 19, 2018
@ansibot ansibot added committer_review In order to be merged, this PR must follow the certified review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. new_contributor This PR is the first contribution by a new community member. labels Dec 19, 2018
@caphrim007 caphrim007 merged commit e9d7c8f into ansible:devel Dec 19, 2018
@wojtek0806 wojtek0806 deleted the bugfix.bigip.pool.member branch December 19, 2018 13:20
kbreit pushed a commit to kbreit/ansible that referenced this pull request Jan 11, 2019
@wojtek0806 @kbreit
fixed an issue with parameter breaking idempotency (ansible#50117)
c113e00 
* fixed an issue with parameter breaking idempotency

* Update bigip_pool_member.py
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. committer_review In order to be merged, this PR must follow the certified review workflow. f5 module This issue/PR relates to a module. networking Network category support:certified This issue/PR relates to certified code.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wojtek0806 @ansibot @caphrim007