Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

win_firewall_rule module documents the bypass action which does not exist. #50143

Closed
dieterv opened this issue Dec 19, 2018 · 4 comments · Fixed by #50207
Closed

win_firewall_rule module documents the bypass action which does not exist. #50143

dieterv opened this issue Dec 19, 2018 · 4 comments · Fixed by #50207
Labels
affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. module This issue/PR relates to a module. python3 support:community This issue/PR relates to code supported by the Ansible community. windows Windows community

Comments

@dieterv
Copy link

dieterv commented Dec 19, 2018

SUMMARY
ISSUE TYPE
  • Bug Report
COMPONENT NAME

win_firewall_rule

ANSIBLE VERSION
ansible 2.7.4
  config file = /redacted/ansible.cfg
  configured module search path = ['/home/redacted/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = /home/redacted/ansible/lib/python3.6/site-packages/ansible
  executable location = /home/redacted/ansible/bin/ansible
  python version = 3.6.6 (default, Sep 12 2018, 18:26:19) [GCC 8.0.1 20180414 (experimental) [trunk revision 259383]]
CONFIGURATION
DEFAULT_VAULT_PASSWORD_FILE(/redacted/ansible.cfg) = /redacted/vault_password_file
INVENTORY_ENABLED(/redacted/ansible.cfg) = ['yaml']
OS / ENVIRONMENT

All.

STEPS TO REPRODUCE
EXPECTED RESULTS
ACTUAL RESULTS

@dieterv dieterv changed the title win_firewall_rule module documents the bypass actions which does not exist. win_firewall_rule module documents the bypass action which does not exist. Dec 19, 2018
@ansibot

This comment has been minimized.

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. needs_info This issue requires further information. Please answer any outstanding questions. needs_template This issue/PR has an incomplete description. Please fill in the proposed template correctly. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Dec 19, 2018
@ansibot
Copy link
Contributor

ansibot commented Dec 20, 2018

@ansibot ansibot added module This issue/PR relates to a module. python3 support:community This issue/PR relates to code supported by the Ansible community. windows Windows community and removed needs_info This issue requires further information. Please answer any outstanding questions. needs_template This issue/PR has an incomplete description. Please fill in the proposed template correctly. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Dec 20, 2018
dagwieers added a commit to dagwieers/ansible that referenced this issue Dec 21, 2018
dagwieers added a commit to dagwieers/ansible that referenced this issue Dec 21, 2018
dagwieers added a commit to dagwieers/ansible that referenced this issue Dec 21, 2018
mahak pushed a commit to mahak/ansible that referenced this issue Dec 21, 2018
* win_firewall_rule: Remove invalid 'bypass' action

This fixes ansible#50143

* Add changelog fragment
@dagwieers
Copy link
Contributor

Thanks for reporting this! I don't know where the action "bypass" is coming from, according to the (linked) documentation it is not supported by the COM object.

I removed the option from the documentation and arg_spec in #50207, and we are backporting this to the stable-2.7 and stable-2.6 branches. So expect this to be fixed in all upcoming releases.

@dieterv
Copy link
Author

dieterv commented Dec 24, 2018

Thank you for the quick fix!

@sivel sivel removed needs_triage Needs a first human triage before being processed. labels Jan 2, 2019
abadger pushed a commit that referenced this issue Jan 7, 2019
)

* win_firewall_rule: Remove invalid 'bypass' action

This fixes #50143

* Add changelog fragment
mattclay pushed a commit that referenced this issue Jan 10, 2019
)

* win_firewall_rule: Remove invalid 'bypass' action

This fixes #50143

* Add changelog fragment
kbreit pushed a commit to kbreit/ansible that referenced this issue Jan 11, 2019
* win_firewall_rule: Remove invalid 'bypass' action

This fixes ansible#50143

* Add changelog fragment
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. module This issue/PR relates to a module. python3 support:community This issue/PR relates to code supported by the Ansible community. windows Windows community
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants