get_url with 1.4 against centos6.4 always downloads URL.

[jeremychase]

The following action will always download the target URL when using Ansible 1.4. It acts as if Force=yes. This test was done with an OSX host against a CentOS6.4 target machine:

• get_url: url=http://downloads.typesafe.com/play/2.2.1/play-2.2.1.zip dest=/tmp

The same get_url against a Debian machine does not exhibit this problem.

[jctanner]

@jeremychase from the get_url module docstrings ...

  force:
    description:
      - If C(yes) and C(dest) is not a directory, will download the file every
        time and replace the file if the contents change. If C(no), the file
        will only be downloaded if the destination does not exist. Generally
        should be C(yes) only for small local files. Prior to 0.6, this module
        behaved as if C(yes) was the default.
        Has no effect if C(dest) is a directory - the file will always be
        downloaded, but replaced only if the contents changed.
    version_added: "0.7"
    required: false
    choices: [ "yes", "no" ]
    default: "no"
    aliases: [ "thirsty" ]

Verified behavior with the following playbook ...

- hosts: [el6.lab.net, localhost]
  gather_facts: False
  tasks:
    - get_url: url=http://tannerjc.net/tmp/screenshots/1.png dest=/tmp
      register: result
      with_sequence: count=4
    - debug: var=result

    - get_url: url=http://tannerjc.net/tmp/screenshots/1.png dest=/tmp/destfile.png
      register: result
      with_sequence: count=4
    - debug: var=result

If dest is a directory name, a temporary filename will be generated and the file will be downloaded every time...

            {
                "changed": false, 
                "dest": "/tmp/destfile.png", 
                "gid": 0, 
                "group": "root", 
                "invocation": {
                    "module_args": "url=http://tannerjc.net/tmp/screenshots/1.png dest=/tmp/destfile.png", 
                    "module_name": "get_url"
                }, 
                "item": "3", 
                "mode": "0644", 
                "msg": "file already exists", 
                "owner": "root", 
                "size": 9466, 
                "state": "file", 
                "uid": 0, 
                "url": "http://tannerjc.net/tmp/screenshots/1.png"
            },

If dest is a filename, the url is fetched if the filename does not exist ....

            {
                "changed": false, 
                "dest": "/tmp/destfile.png", 
                "gid": 0, 
                "group": "root", 
                "invocation": {
                    "module_args": "url=http://tannerjc.net/tmp/screenshots/1.png dest=/tmp/destfile.png", 
                    "module_name": "get_url"
                }, 
                "item": "3", 
                "mode": "0644", 
                "msg": "file already exists", 
                "owner": "root", 
                "size": 9466, 
                "state": "file", 
                "uid": 0, 
                "url": "http://tannerjc.net/tmp/screenshots/1.png"
            },

[jeremychase]

@jctanner Ahh. Sorry for the trouble.

[jctanner]

@jeremychase np, it gave me a chance to review the module.

[paulmaunders]

This had bugged me for ages! I didn't realise you had to explicitly set the dest filename to ensure it doesn't download it everytime.