Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

win_firewall_rule: Remove invalid 'bypass' action #50207

Merged
merged 2 commits into from
Dec 21, 2018
Merged

win_firewall_rule: Remove invalid 'bypass' action #50207

merged 2 commits into from
Dec 21, 2018

Conversation

dagwieers
Copy link
Contributor

This fixes #50143

This PR also includes some documentation fixes.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

win_firewall_rule

@ansibot
Copy link
Contributor

ansibot commented Dec 20, 2018

cc @timothyvandenbrande @ar7z1 @jborean93 @jhawkesworth @nitzmahone
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. owner_pr This PR is made by the module's maintainer. support:community This issue/PR relates to code supported by the Ansible community. windows Windows community labels Dec 20, 2018
@dagwieers dagwieers mentioned this pull request Dec 21, 2018
Merged
@jborean93
Copy link
Contributor

The bypass option was added with ansible/ansible-modules-extras#2432 but it added no purpose. Removing this to remove confusion as there is no need for it to be there.

This was referenced Dec 21, 2018
Closed
Merged
@jborean93 jborean93 merged commit 0fe7d56 into ansible:devel Dec 21, 2018
@dagwieers dagwieers mentioned this pull request Dec 21, 2018
Closed
@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Jan 4, 2019
kbreit pushed a commit to kbreit/ansible that referenced this pull request Jan 11, 2019
@dagwieers @kbreit
win_firewall_rule: Remove invalid 'bypass' action (ansible#50207)
2fe0b1e 
* win_firewall_rule: Remove invalid 'bypass' action

This fixes ansible#50143

* Add changelog fragment
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jborean93 jborean93 jborean93 approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. owner_pr This PR is made by the module's maintainer. support:community This issue/PR relates to code supported by the Ansible community. windows Windows community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

win_firewall_rule module documents the bypass action which does not exist.
4 participants
@dagwieers @ansibot @jborean93 @sivel