Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ansible test: re-enable mysql tests with fix #50430

Merged
merged 1 commit into from
Jan 3, 2019
Merged

ansible test: re-enable mysql tests with fix #50430

merged 1 commit into from
Jan 3, 2019

Conversation

jborean93
Copy link
Contributor

@jborean93 jborean93 commented Jan 2, 2019 •
edited

SUMMARY

The setup_mysql_db integration test target installs packages at the latest version which results in mariadb-server to install Python 2 and break that test environment. This PR changes the setup to only install if it is needed as mariadb-server is already pre-installed https://github.com/ansible/distro-test-containers/blob/master/fedora29-test-container/Dockerfile#L27 and also simplifies the steps.

The original code to install the latest was added when the test was created 24a3d55 but I'm not sure if there is a valid reason to add more moving parts to the test.

Fixes #50386
Fixes #50394

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ansible-test integration tests for

  • mysql_db
  • mysql_user
  • mysql_variables
  • zabbix_host

@ansibot
Copy link
Contributor

ansibot commented Jan 2, 2019

cc @D3DeFi @Jmainguy @banyek @cove @dj-wasabi @eikef @harrisongu
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. labels Jan 2, 2019
@jborean93
Copy link
Contributor Author

cc @gundalow

@jamescassell
Copy link
Contributor

shipit

@Akasurde
Copy link
Member

Akasurde commented Jan 2, 2019

also fixes: #50387

@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Jan 2, 2019
@maxamillion
Copy link
Contributor

shipit

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. labels Jan 2, 2019
@jamescassell
Copy link
Contributor

bot_status

@Akasurde Akasurde mentioned this pull request Jan 3, 2019
Merged
@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed shipit This PR is ready to be merged by Core labels Jan 3, 2019
@jborean93
Copy link
Contributor Author

Have updated the tests to keep the old behaviour of installing the latest but fixing the weak dependency bringing in Python 2.

@jborean93 jborean93 merged commit 6620fac into ansible:devel Jan 3, 2019
@jborean93 jborean93 deleted the test-mysql branch January 3, 2019 21:14
jborean93 added a commit to jborean93/ansible that referenced this pull request Jan 3, 2019
@jborean93
ansible test: re-enable mysql tests with fix (ansible#50430)
a6862a6 
(cherry picked from commit 6620fac)
jborean93 added a commit to jborean93/ansible that referenced this pull request Jan 3, 2019
@jborean93
ansible test: re-enable mysql tests with fix (ansible#50430)
264f6e3 
(cherry picked from commit 6620fac)
jborean93 added a commit to jborean93/ansible that referenced this pull request Jan 3, 2019
@jborean93
ansible test: re-enable mysql tests with fix (ansible#50430)
a5ee8da 
(cherry picked from commit 6620fac)
This was referenced Jan 3, 2019
Merged
Merged
@jborean93 jborean93 mentioned this pull request Jan 3, 2019
Merged
@jborean93
Copy link
Contributor Author

Backport PRs
stable-2.5 #50519
stable-2.6 #50520
stable-2.7 #50521

@Akasurde Akasurde mentioned this pull request Jan 4, 2019
Closed
abadger pushed a commit that referenced this pull request Jan 7, 2019
@jborean93 @abadger
ansible test: re-enable mysql tests with fix (#50430)
9a4d17e 
(cherry picked from commit 6620fac)
nitzmahone pushed a commit that referenced this pull request Jan 7, 2019
@jborean93 @nitzmahone
ansible test: re-enable mysql tests with fix (#50430) (#50519)
c93c4fd 
(cherry picked from commit 6620fac)
mattclay pushed a commit that referenced this pull request Jan 7, 2019
@jborean93 @mattclay
ansible test: re-enable mysql tests with fix (#50430)
23a633a 
(cherry picked from commit 6620fac)
kbreit pushed a commit to kbreit/ansible that referenced this pull request Jan 11, 2019
@jborean93 @kbreit
ansible test: re-enable mysql tests with fix (ansible#50430)
5580a9f
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gundalow gundalow Awaiting requested review from gundalow

@mattclay mattclay Awaiting requested review from mattclay

@maxamillion maxamillion Awaiting requested review from maxamillion

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. mysql support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mysql_user testcase failing mysql_db test installing Python 2
6 participants
@jborean93 @ansibot @jamescassell @Akasurde @maxamillion @dagwieers