VMware: Update vmware_object_role_permission to allow permissions at root folder

[vmwjoseph]

SUMMARY

Bug fixes

• self.is_group wasn't set when applying permissions to users.
• Use to_native for exceptions.

Enhancements

• Add check mode.
• Add ability to apply permission at the root folder level.
• Cleanup formatting

ISSUE TYPE

• Feature Pull Request

COMPONENT NAME

vmware_object_role_permission

ADDITIONAL INFORMATION

Before changes - when applying to a principal that isn't a group

The full traceback is:
Traceback (most recent call last):
  File "/tmp/ansible_YZIAiT/ansible_module_vmware_object_role_permission.py", line 238, in <module>
    main()
  File "/tmp/ansible_YZIAiT/ansible_module_vmware_object_role_permission.py", line 233, in main
    vmware_object_permission = VMwareObjectRolePermission(module)
  File "/tmp/ansible_YZIAiT/ansible_module_vmware_object_role_permission.py", line 127, in __init__
    self.perm = self.setup_permission()
  File "/tmp/ansible_YZIAiT/ansible_module_vmware_object_role_permission.py", line 169, in setup_permission
    perm.group = self.is_group
AttributeError: 'VMwareObjectRolePermission' object has no attribute 'is_group'

failed: [10.193.30.210 -> localhost] (item={u'object_name': u'N-folder', u'object_type': u'Folder', u'role': u'N-User', u'principal': u'myuser'}) => {
    "changed": false, 
    "item": {
        "object_name": "N-folder", 
        "object_type": "Folder", 
        "principal": "myuser", 
        "role": "N-User"
    }, 
    "module_stderr": "Traceback (most recent call last):\n  File \"/tmp/ansible_YZIAiT/ansible_module_vmware_object_role_permission.py\", line 238, in <module>\n    main()\n  File \"/tmp/ansible_YZIAiT/ansible_module_vmware_object_role_permission.py\", line 233, in main\n    vmware_object_permission = VMwareObjectRolePermission(module)\n  File \"/tmp/ansible_YZIAiT/ansible_module_vmware_object_role_permission.py\", line 127, in __init__\n    self.perm = self.setup_permission()\n  File \"/tmp/ansible_YZIAiT/ansible_module_vmware_object_role_permission.py\", line 169, in setup_permission\n    perm.group = self.is_group\nAttributeError: 'VMwareObjectRolePermission' object has no attribute 'is_group'\n", 
    "module_stdout": "", 
    "msg": "MODULE FAILURE", 
    "rc": 1
}

After changes

changed: [10.193.30.210 -> localhost] => (item={u'object_name': u'N-Folder', u'object_type': u'Folder', u'role': u'N-User', u'principal': u'myuser'}) => {
    "changed": true, 
    "invocation": {
        "module_args": {
            "group": null, 
            "hostname": "10.193.30.210", 
            "object_name": "N-Folder", 
            "object_type": "Folder", 
            "password": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER", 
            "port": 443, 
            "principal": "myuser", 
            "recursive": true, 
            "role": "N-User", 
            "state": "present", 
            "username": "administrator@vsphere.local", 
            "validate_certs": false
        }
    }, 
    "item": {
        "object_name": "N-Folder", 
        "object_type": "Folder", 
        "principal": "myuser", 
        "role": "N-User"
    }
}

[ansibot]

cc @Akasurde @ckotte @dav1x @kryptsi @warthog9
click here for bot help

[ansibot]

@vmwjoseph, just so you are aware we have a dedicated Working Group for vmware.
You can find other people interested in this in #ansible-vmware on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

[ansibot]

cc @lparkes
click here for bot help

[ansibot]

cc @Tomorrow9
click here for bot help

[Akasurde]

LGTM

[Akasurde]

@pdellaert @dericcrago @Im0 @ckotte @jeking3 @Tomorrow9 Could you please review this ?

[jeking3]

More reformatting done than fixing and enabled check_mode, the real fix is at lines 207-209.