Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VMware: add new module vmware_export_ovf #50589

Merged
merged 3 commits into from
Feb 25, 2019
Merged

VMware: add new module vmware_export_ovf #50589

merged 3 commits into from
Feb 25, 2019

Conversation

Tomorrow9
Copy link
Contributor

SUMMARY
Create a new module named "vmware_export_ovf" to export VM to ovf template.

Fixes #42397

ISSUE TYPE
New Module Pull Request
COMPONENT NAME
vmware_export_ovf

ADDITIONAL INFORMATION
hosts: localhost
tasks:
name: test export ovf
vmware_export_ovf:
validate_certs: no
hostname: test.eng.com
username: root
password: test
name: test-debian9.4
datacenter: 6.7GA
export_dir: /tmp/
export_with_images: true
register: export_ovf

@ansibot
Copy link
Contributor

ansibot commented Jan 7, 2019

cc @Akasurde @ckotte @dav1x @warthog9
click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Jan 7, 2019

@Tomorrow9, just so you are aware we have a dedicated Working Group for vmware.
You can find other people interested in this in #ansible-vmware on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 cloud community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community. vmware VMware community labels Jan 7, 2019
@ansibot
Copy link
Contributor

ansibot commented Jan 7, 2019

@MikeKlebolt @Akasurde @bedecarroll @CastawayEGR @chrrrles @dav1x @garbled1 @imjoseangel @jjahns @kamsz @kryptsi @lrivallain @nafpliot-ibm @nerzhul @oboukili @rhoop @ritzk @rmin @stravassac @tchernomax @warthog9 @woshihaoren

As a maintainer of a module in the same namespace this new module has been submitted to, your vote counts for shipits. Please review this module and add shipit if you would like to see it merged.

click here for bot help

@Tomorrow9
Copy link
Contributor Author

@Akasurde I've moved comments from @jeking3, from #50233 to here. Thanks.

@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jan 15, 2019
@Akasurde Akasurde requested a review from sivel January 21, 2019 04:40
@Akasurde Akasurde removed the needs_triage Needs a first human triage before being processed. label Jan 21, 2019
@Akasurde
Copy link
Member

@pdellaert @dericcrago @Im0 @tchernomax @ckotte @jeking3 Could you please review this ?

jeking3
jeking3 approved these changes Jan 21, 2019
View reviewed changes
Copy link
Contributor

@jeking3 jeking3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had only minor improvements that could be made. There is no integration test for this, and I'm not sure the simulator would be able to do it... without an integration test and without unit tests, it could rot easily.

lib/ansible/module_utils/vmware.py Show resolved Hide resolved
lib/ansible/module_utils/vmware.py Outdated Show resolved Hide resolved
lib/ansible/modules/cloud/vmware/vmware_export_ovf.py Show resolved Hide resolved
lib/ansible/modules/cloud/vmware/vmware_export_ovf.py Outdated Show resolved Hide resolved
@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jan 22, 2019
pdellaert
pdellaert approved these changes Jan 28, 2019
View reviewed changes
Copy link
Contributor

@pdellaert pdellaert left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall from a code perspective, will test in my environment tomorrow

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. labels Jan 28, 2019
@gundalow
Copy link
Contributor

gundalow commented Feb 4, 2019

@pdellaert Hi, did you get a chance to test this?

@ansibot
Copy link
Contributor

ansibot commented Feb 17, 2019

cc @lparkes
click here for bot help

@Akasurde
Copy link
Member

@Tomorrow9 There is one pending comment related to StrictVersion check ? Could you please address and let me know so that we can proceed with the merge ? Thanks.

@Tomorrow9
Copy link
Contributor Author

@Akasurde Hi, I've made the change according to that review comment. Thanks.

@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed shipit This PR is ready to be merged by Core labels Feb 25, 2019
@Akasurde Akasurde merged commit 4f8cd6b into ansible:devel Feb 25, 2019
@Akasurde
Copy link
Member

@Tomorrow9 Thanks for the contribution.

@Tomorrow9 Tomorrow9 deleted the fix_pr42397 branch February 25, 2019 04:17
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Akasurde Akasurde Akasurde left review comments

@pdellaert pdellaert pdellaert approved these changes

@jeking3 jeking3 jeking3 approved these changes

@sivel sivel Awaiting requested review from sivel

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 cloud community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community. vmware VMware community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

VMware: export an ovf file from a Virtual Machine on vSphere vCenter
6 participants
@Tomorrow9 @ansibot @Akasurde @gundalow @pdellaert @jeking3