Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add backup filename and dir path option for config network modules #50801

Merged
merged 4 commits into from Jan 24, 2019
Merged

Add backup filename and dir path option for config network modules #50801

merged 4 commits into from Jan 24, 2019

Conversation

ganeshrn
Copy link
Member

@ganeshrn ganeshrn commented Jan 11, 2019 •
edited

SUMMARY

Fixes #50283
Fixes #32724

  • Add back_options in network config module argspec to allow backup filename and directory path
    to be configurable.
  • Handle backup path options in network action plugin
ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

aireos_config
aruba_config
asa_config
cli_config
ce_config
cnos_config
dellos10_config
dellos6_config
dellos9_config
edgeos_config
enos_config
eos_config
exos_config
bigip_imish_config
ios_config
iosxr_config
ironware_config
junos_config
netconf_config
nos_config
nxos_config
onyx_config
slxos_config
sros_config
voss_config
vyos_config
plugins/action/bigip.py
plugins/action/network.py

ADDITIONAL INFORMATION

@ganeshrn
Add configurable backup path option for network config modules
bf80643 
Fixes ansible#50283
Fixes ansible#32724

*  Add back_options in network config module argspec
*  Handle backup path options in network action plugin
@ansibot
Copy link
Contributor

ansibot commented Jan 11, 2019

cc @Dhivyap @LindsayHill @QijunPan @abirami-n @amuraleedhar @anasbadaha @atabachnik @bigmstone @caphrim007 @Dhivyap @dkasberg @hlrichardson @jmighion @lpenz @mikewiebe @ogenstad @paulquack @privateip @Qalthos @rahushen @rdvencioneck @samdoran @samerd @skg-net @tstoner @userlerueda
click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Jan 11, 2019

@ganeshrn, just so you are aware we have a dedicated Working Group for network.
You can find other people interested in this in #ansible-network on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 core_review In order to be merged, this PR must follow the core review workflow. f5 feature This issue/PR relates to a feature request. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category nxos Cisco NXOS community support:certified This issue/PR relates to certified code. support:community This issue/PR relates to code supported by the Ansible community. support:network This issue/PR relates to code supported by the Ansible Network Team. labels Jan 11, 2019
@ganeshrn ganeshrn mentioned this pull request Jan 11, 2019
Merged
@ganeshrn ganeshrn changed the title Add configurable backup path option for network config modules Add backup filename and dir path option for config network modules Jan 11, 2019
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Jan 11, 2019
samccann
samccann reviewed Jan 11, 2019
View reviewed changes
Copy link
Contributor

@samccann samccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like a lot of comments, but it's the same two doc nits in every file :-)

lib/ansible/modules/network/aireos/aireos_config.py Outdated Show resolved Hide resolved
lib/ansible/modules/network/aireos/aireos_config.py Outdated Show resolved Hide resolved
lib/ansible/modules/network/aruba/aruba_config.py Outdated Show resolved Hide resolved
lib/ansible/modules/network/aruba/aruba_config.py Outdated Show resolved Hide resolved
lib/ansible/modules/network/asa/asa_config.py Outdated Show resolved Hide resolved
lib/ansible/modules/network/sros/sros_config.py Outdated Show resolved Hide resolved
lib/ansible/modules/network/voss/voss_config.py Outdated Show resolved Hide resolved
lib/ansible/modules/network/voss/voss_config.py Outdated Show resolved Hide resolved
lib/ansible/modules/network/vyos/vyos_config.py Outdated Show resolved Hide resolved
lib/ansible/modules/network/vyos/vyos_config.py Outdated Show resolved Hide resolved
@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Jan 11, 2019
@ansible ansible deleted a comment from ansibot Jan 14, 2019
@ganeshrn
Copy link
Member Author

Please add test for this.

Added integration test cases

@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jan 15, 2019
@ganeshrn ganeshrn mentioned this pull request Jan 16, 2019
Closed
justjais
justjais approved these changes Jan 16, 2019
View reviewed changes
Copy link
Contributor

@justjais justjais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed core_review In order to be merged, this PR must follow the core review workflow. labels Jan 16, 2019
gundalow
gundalow requested changes Jan 18, 2019
View reviewed changes
Copy link
Contributor

@gundalow gundalow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add a changelog/fragment for this. I think it's a worthwhile change to highlight.

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed shipit This PR is ready to be merged by Core labels Jan 18, 2019
@ganeshrn
Copy link
Member Author

Could you please add a changelog/fragment for this. I think it's a worthwhile change to highlight.

Added changelog entry

gundalow
gundalow approved these changes Jan 18, 2019
View reviewed changes
Copy link
Contributor

@gundalow gundalow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, merge at will

@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jan 21, 2019
@ganeshrn ganeshrn merged commit 70bf9b9 into ansible:devel Jan 24, 2019
@ganeshrn ganeshrn deleted the backup_path_configrurable branch January 24, 2019 04:06
@wojtek0806 wojtek0806 mentioned this pull request Feb 2, 2019
Closed
@dagwieers dagwieers added asa Cisco ASA community cisco Cisco technologies iosxr Cisco IOSXR community labels Feb 22, 2019
This was referenced Jun 14, 2019
Merged
Merged
@mjbnz
Copy link

mjbnz commented Jul 24, 2019

Looks like this also fixed #28879

@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@samccann samccann samccann left review comments

@Qalthos Qalthos Qalthos approved these changes

@gundalow gundalow gundalow approved these changes

@trishnaguha trishnaguha trishnaguha approved these changes

@NilashishC NilashishC NilashishC approved these changes

@justjais justjais justjais approved these changes

@gdpak gdpak Awaiting requested review from gdpak

@caphrim007 caphrim007 Awaiting requested review from caphrim007

@privateip privateip Awaiting requested review from privateip

@rcarrillocruz rcarrillocruz Awaiting requested review from rcarrillocruz

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 asa Cisco ASA community cisco Cisco technologies core_review In order to be merged, this PR must follow the core review workflow. f5 feature This issue/PR relates to a feature request. iosxr Cisco IOSXR community module This issue/PR relates to a module. networking Network category nxos Cisco NXOS community support:certified This issue/PR relates to certified code. support:community This issue/PR relates to code supported by the Ansible community. support:network This issue/PR relates to code supported by the Ansible Network Team. test This PR relates to tests.
Projects
None yet
Milestone
No milestone