Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cli_config backup option check #50926

Merged
merged 1 commit into from
Jan 15, 2019
Merged

Fix cli_config backup option check #50926

merged 1 commit into from
Jan 15, 2019

Conversation

ganeshrn
Copy link
Member

SUMMARY

Fixes #50925

  • If config or rollback option is None and backup=yes in
    that case add check so edit_config() is not invoked as
    it is not required.
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

cli_config

ADDITIONAL INFORMATION

@ganeshrn
Fix cli_config backup option check
a7badbf 
Fixes ansible#50925

*  If config or rollback option is None and backup=yes in
   that case add check so edit_config() is not invoked as
   it is not required.
@ansibot
Copy link
Contributor

ansibot commented Jan 15, 2019

cc @trishnaguha
click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Jan 15, 2019

@ganeshrn, just so you are aware we have a dedicated Working Group for network.
You can find other people interested in this in #ansible-network on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category support:network This issue/PR relates to code supported by the Ansible Network Team. labels Jan 15, 2019
@ganeshrn ganeshrn removed the needs_triage Needs a first human triage before being processed. label Jan 15, 2019
@ganeshrn ganeshrn merged commit 9d54e58 into ansible:devel Jan 15, 2019
@ganeshrn ganeshrn deleted the cli_config_backup_fix branch January 15, 2019 11:18
knumskull pushed a commit to knumskull/ansible that referenced this pull request Jan 21, 2019
@ganeshrn @knumskull
Fix cli_config backup option check (ansible#50926)
1c21968 
Fixes ansible#50925

*  If config or rollback option is None and backup=yes in
   that case add check so edit_config() is not invoked as
   it is not required.
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@trishnaguha trishnaguha Awaiting requested review from trishnaguha

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. networking Network category support:network This issue/PR relates to code supported by the Ansible Network Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cli_config module fails on eos while taking config backup
2 participants
@ganeshrn @ansibot