Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Match VLAN ID as whole line instead of searching for digits in line #51019

Merged
merged 1 commit into from
Jan 17, 2019
Merged

Match VLAN ID as whole line instead of searching for digits in line #51019

merged 1 commit into from
Jan 17, 2019

Conversation

ajsiersema
Copy link
Contributor

SUMMARY

Searching for digits somewhere in the output line will also match VLAN name (lines) starting with digits.

Fixes issue #50998

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

nxos_vlan

ADDITIONAL INFORMATION

@ajsiersema
Match VLAN ID as whole line instead of searching for digits in line
8f87226 
Searching for digits somewhere in the output line will also match VLAN name (lines) starting with digits.

Fixes issue #50998
@ansibot
Copy link
Contributor

ansibot commented Jan 17, 2019

cc @jedelman8 @mikewiebe @rahushen @rcarrillocruz @trishnaguha @tstoner
click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Jan 17, 2019

@ajsiersema, just so you are aware we have a dedicated Working Group for network.
You can find other people interested in this in #ansible-network on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category new_contributor This PR is the first contribution by a new community member. nxos Cisco NXOS community small_patch support:network This issue/PR relates to code supported by the Ansible Network Team. labels Jan 17, 2019
@trishnaguha trishnaguha self-assigned this Jan 17, 2019
@trishnaguha trishnaguha removed the needs_triage Needs a first human triage before being processed. label Jan 17, 2019
trishnaguha
trishnaguha approved these changes Jan 17, 2019
View reviewed changes
Copy link
Member

@trishnaguha trishnaguha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR

@trishnaguha trishnaguha merged commit b1c2953 into ansible:devel Jan 17, 2019
@trishnaguha trishnaguha mentioned this pull request Jan 17, 2019
Closed
@ajsiersema ajsiersema deleted the issue50998 branch January 17, 2019 12:26
knumskull pushed a commit to knumskull/ansible that referenced this pull request Jan 21, 2019
@ajsiersema @knumskull
Match VLAN ID as whole line instead of searching for digits in line (a…
8731924 
…nsible#51019)

Searching for digits somewhere in the output line will also match VLAN name (lines) starting with digits.

Fixes issue ansible#50998
@dagwieers dagwieers added the cisco Cisco technologies label Feb 22, 2019
trishnaguha pushed a commit to trishnaguha/ansible that referenced this pull request Apr 1, 2019
@ajsiersema @trishnaguha
Match VLAN ID as whole line instead of searching for digits in line (a…
9d1727d 
…nsible#51019)

Searching for digits somewhere in the output line will also match VLAN name (lines) starting with digits.

Fixes issue ansible#50998

(cherry picked from commit b1c2953)
abadger pushed a commit that referenced this pull request Apr 4, 2019
@ajsiersema @abadger
Match VLAN ID as whole line instead of searching for digits in line (#…
41d9999 
…51019)

Searching for digits somewhere in the output line will also match VLAN name (lines) starting with digits.

Fixes issue #50998

(cherry picked from commit b1c2953)
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@trishnaguha trishnaguha trishnaguha approved these changes

Assignees

@trishnaguha trishnaguha

Labels
affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. cisco Cisco technologies core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. networking Network category new_contributor This PR is the first contribution by a new community member. nxos Cisco NXOS community small_patch support:network This issue/PR relates to code supported by the Ansible Network Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ajsiersema @ansibot @trishnaguha @dagwieers