Fix 'defaults' option in the nxos_config module #51076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nxos get_config is allways called with the 'all' option. * Fix flag's calculation * Add tests
|
@OlivierB, just so you are aware we have a dedicated Working Group for network. |
ansibot
added
affects_2.8
ansibot
removed
the
needs_triage
trishnaguha
suggested changes
Jan 22, 2019
| @@ -290,9 +290,12 @@ def get_running_config(module, config=None): | |||
| contents = module.params['running_config'] | |||
| if not contents: | |||
| if not module.params['defaults'] and config: | |||
| # Optimization: The running-config has already been recovered by the backup | |||
There was a problem hiding this comment.
To make it work, not module.params['defaults'] needs to be removed from this condition.
ansibot
added
needs_revision
trishnaguha
reviewed
Jan 22, 2019
There was a problem hiding this comment.
@OlivierB Also instead of only fixing it in get_running_config, I would something like trishnaguha@4f34349
|
@trishnaguha OK ! |
…ults' option If 'defaults' option is true, the running-config backup is done with the all keyword.
trishnaguha
pushed a commit
to trishnaguha/ansible
that referenced
this pull request
Apr 1, 2019
* Fix 'defaults' option in the nxos_config module Nxos get_config is allways called with the 'all' option. * Fix flag's calculation * Add tests * nxos_config: the 'backup' option take into account the value of 'defaults' option If 'defaults' option is true, the running-config backup is done with the all keyword. (cherry picked from commit 87a01df)
OlivierB
added a commit
to Alphalink/ansible
that referenced
this pull request
Apr 1, 2019
(cherry picked from commit 87a01df) * Fix 'defaults' option in the nxos_config module Nxos get_config is allways called with the 'all' option. * Fix flag's calculation * Add tests * nxos_config: the 'backup' option take into account the value of 'defaults' option If 'defaults' option is true, the running-config backup is done with the all keyword.
abadger
pushed a commit
that referenced
this pull request
Apr 4, 2019
* Fix 'defaults' option in the nxos_config module Nxos get_config is allways called with the 'all' option. * Fix flag's calculation * Add tests * nxos_config: the 'backup' option take into account the value of 'defaults' option If 'defaults' option is true, the running-config backup is done with the all keyword. (cherry picked from commit 87a01df)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Nxos get_config is allways called with the 'all' option.
ISSUE TYPE
COMPONENT NAME
nxos_config
ADDITIONAL INFORMATION
I have not changed the backup behavior as in the eos_config module.