Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Module: na_ontap_vscan_on_demand_task #51183

Merged
merged 4 commits into from
Feb 21, 2019
Merged

New Module: na_ontap_vscan_on_demand_task #51183

merged 4 commits into from
Feb 21, 2019

Conversation

carchi8py
Copy link
Contributor

SUMMARY

New Module: na_ontap_vscan_on_demand_task -- allow configuration of Vscan on demand tasks

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME
  • na_ontap_vscan_on_demand_task
ADDITIONAL INFORMATION

@carchi8py
changes to clusteR
6ec9343
@carchi8py
Revert "changes to clusteR"
9bda18d 
This reverts commit 33ee1b71e4bc8435fb315762a871f8c4cb6c5f80.
@carchi8py
Add vscan on demand task
9bae19f
@ansibot
Copy link
Contributor

ansibot commented Jan 22, 2019

cc @amit0701 @hulquest @lmprice @lonico @ndswartz @schmots1
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. netapp new_module This PR includes a new module. new_plugin This PR includes a new plugin. storage support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Jan 22, 2019
@ansibot
Copy link
Contributor

ansibot commented Jan 22, 2019

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/storage/netapp/na_ontap_vscan_on_demand_task.py:0:0: E305 DOCUMENTATION.author: Invalid author for dictionary value @ data['author']. Got 'NetApp Ansible Team (ng-ansibleteam@netapp.com)'

click here for bot help

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Jan 22, 2019
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jan 22, 2019
@samdoran samdoran removed needs_triage Needs a first human triage before being processed. labels Jan 22, 2019
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Feb 2, 2019
lonico
lonico approved these changes Feb 15, 2019
View reviewed changes
Copy link
Contributor

@lonico lonico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed core_review In order to be merged, this PR must follow the core review workflow. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Feb 15, 2019
@beeankha
Copy link
Contributor

Tested locally, all succeeded. 👍

beeankha
beeankha approved these changes Feb 19, 2019
View reviewed changes
Copy link
Contributor

@beeankha beeankha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, all looks good to me.

@gundalow gundalow merged commit a60740a into ansible:devel Feb 21, 2019
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lonico lonico lonico approved these changes

@beeankha beeankha beeankha approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 module This issue/PR relates to a module. netapp new_module This PR includes a new module. new_plugin This PR includes a new plugin. shipit This PR is ready to be merged by Core storage support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@carchi8py @ansibot @beeankha @lonico @gundalow @samdoran