Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

itential iap_start_workflow module #51238

Merged
merged 22 commits into from
Mar 7, 2019
Merged

itential iap_start_workflow module #51238

merged 22 commits into from
Mar 7, 2019

Conversation

bhansalij21
Copy link
Contributor

SUMMARY

Start a workflow in the Itential Automation Platform

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

iap_start_workflow.py

ADDITIONAL INFORMATION

N/A

@ansibot
Copy link
Contributor

ansibot commented Jan 23, 2019

cc @NilashishC @Qalthos @cma0 @ganeshrn @gdpak @justjais @rcarrillocruz @trishnaguha
click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Jan 23, 2019

@bhansalij21, just so you are aware we have a dedicated Working Group for network.
You can find other people interested in this in #ansible-network on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category new_contributor This PR is the first contribution by a new community member. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. labels Jan 23, 2019
@ansibot ansibot added the new_module This PR includes a new module. label Jan 23, 2019
@ansibot
Copy link
Contributor

ansibot commented Jan 23, 2019

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/network/itential/iap_start_workflow.py:0:0: E319 RETURN.response.type: not a valid value for dictionary value @ data['response']['type']. Got 'obj'

click here for bot help

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Jan 23, 2019
@ansibot ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label Jan 23, 2019
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jan 23, 2019
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Feb 1, 2019
@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Feb 24, 2019
@ansibot
Copy link
Contributor

ansibot commented Feb 24, 2019

The test ansible-test sanity --test pylint [explain] failed with 3 errors:

test/units/modules/network/itential/test_iap_start_workflow.py:36:15: bad-whitespace Exactly one space required after assignment         params ={"description": "NewTestAnsible",                ^
test/units/modules/network/itential/test_iap_start_workflow.py:895:0: missing-final-newline Final newline missing
test/units/modules/network/itential/test_iap_start_workflow.py:895:0: mixed-line-endings Mixed line endings LF and CRLF

The test ansible-test sanity --test pep8 [explain] failed with 18 errors:

test/units/modules/network/itential/test_iap_start_workflow.py:36:17: E225 missing whitespace around operator
test/units/modules/network/itential/test_iap_start_workflow.py:37:17: E128 continuation line under-indented for visual indent
test/units/modules/network/itential/test_iap_start_workflow.py:38:17: E128 continuation line under-indented for visual indent
test/units/modules/network/itential/test_iap_start_workflow.py:39:17: E128 continuation line under-indented for visual indent
test/units/modules/network/itential/test_iap_start_workflow.py:40:17: E128 continuation line under-indented for visual indent
test/units/modules/network/itential/test_iap_start_workflow.py:41:17: E128 continuation line under-indented for visual indent
test/units/modules/network/itential/test_iap_start_workflow.py:42:17: E128 continuation line under-indented for visual indent
test/units/modules/network/itential/test_iap_start_workflow.py:45:17: E126 continuation line over-indented for hanging indent
test/units/modules/network/itential/test_iap_start_workflow.py:47:27: E231 missing whitespace after ':'
test/units/modules/network/itential/test_iap_start_workflow.py:49:17: E126 continuation line over-indented for hanging indent
test/units/modules/network/itential/test_iap_start_workflow.py:145:161: E501 line too long (169 > 160 characters)
test/units/modules/network/itential/test_iap_start_workflow.py:201:161: E501 line too long (185 > 160 characters)
test/units/modules/network/itential/test_iap_start_workflow.py:468:13: E121 continuation line under-indented for hanging indent
test/units/modules/network/itential/test_iap_start_workflow.py:470:17: E126 continuation line over-indented for hanging indent
test/units/modules/network/itential/test_iap_start_workflow.py:566:161: E501 line too long (169 > 160 characters)
test/units/modules/network/itential/test_iap_start_workflow.py:622:161: E501 line too long (185 > 160 characters)
test/units/modules/network/itential/test_iap_start_workflow.py:889:13: E121 continuation line under-indented for hanging indent
test/units/modules/network/itential/test_iap_start_workflow.py:895:20: W292 no newline at end of file

click here for bot help

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Feb 24, 2019
@ansibot
Copy link
Contributor

ansibot commented Feb 24, 2019

The test ansible-test sanity --test pep8 [explain] failed with 18 errors:

test/units/modules/network/itential/test_iap_start_workflow.py:146:161: E501 line too long (169 > 160 characters)
test/units/modules/network/itential/test_iap_start_workflow.py:171:17: E122 continuation line missing indentation or outdented
test/units/modules/network/itential/test_iap_start_workflow.py:202:161: E501 line too long (185 > 160 characters)
test/units/modules/network/itential/test_iap_start_workflow.py:228:17: E122 continuation line missing indentation or outdented
test/units/modules/network/itential/test_iap_start_workflow.py:288:17: E122 continuation line missing indentation or outdented
test/units/modules/network/itential/test_iap_start_workflow.py:344:17: E122 continuation line missing indentation or outdented
test/units/modules/network/itential/test_iap_start_workflow.py:394:17: E122 continuation line missing indentation or outdented
test/units/modules/network/itential/test_iap_start_workflow.py:401:17: E122 continuation line missing indentation or outdented
test/units/modules/network/itential/test_iap_start_workflow.py:413:17: E122 continuation line missing indentation or outdented
test/units/modules/network/itential/test_iap_start_workflow.py:567:161: E501 line too long (169 > 160 characters)
test/units/modules/network/itential/test_iap_start_workflow.py:592:17: E122 continuation line missing indentation or outdented
test/units/modules/network/itential/test_iap_start_workflow.py:623:161: E501 line too long (185 > 160 characters)
test/units/modules/network/itential/test_iap_start_workflow.py:649:17: E122 continuation line missing indentation or outdented
test/units/modules/network/itential/test_iap_start_workflow.py:709:17: E122 continuation line missing indentation or outdented
test/units/modules/network/itential/test_iap_start_workflow.py:765:17: E122 continuation line missing indentation or outdented
test/units/modules/network/itential/test_iap_start_workflow.py:816:17: E122 continuation line missing indentation or outdented
test/units/modules/network/itential/test_iap_start_workflow.py:823:17: E122 continuation line missing indentation or outdented
test/units/modules/network/itential/test_iap_start_workflow.py:835:17: E122 continuation line missing indentation or outdented

click here for bot help

@jborean93 jborean93 added the ci_verified Changes made in this PR are causing tests to fail. label Feb 25, 2019
@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Feb 25, 2019
@bhansalij21 bhansalij21 mentioned this pull request Feb 27, 2019
Closed
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Feb 28, 2019
@Qalthos Qalthos merged commit 85ba4d7 into ansible:devel Mar 7, 2019
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. networking Network category new_contributor This PR is the first contribution by a new community member. new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bhansalij21 @ansibot @Qalthos @jborean93