Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

junos_config documentation missing "update" choice #51299

Merged
merged 2 commits into from
Jan 30, 2019
Merged

junos_config documentation missing "update" choice #51299

merged 2 commits into from
Jan 30, 2019

Conversation

crab86
Copy link
Contributor

@crab86 crab86 commented Jan 24, 2019

SUMMARY

The current junos_config module documentation only lists "merge","override" and "replace" as update parameter choices. Looking into junos_python.py "update" is another option which is really helpful and in my opinion the most needed option.

update=dict(default='merge', choices=['merge', 'override', 'replace', 'update'])
ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

junos_config

@ansibot
Copy link
Contributor

ansibot commented Jan 24, 2019

The test ansible-test sanity --test pep8 [explain] failed with 5 errors:

lib/ansible/modules/network/junos/junos_config.py:116:86: W291 trailing whitespace
lib/ansible/modules/network/junos/junos_config.py:117:89: W291 trailing whitespace
lib/ansible/modules/network/junos/junos_config.py:118:84: W291 trailing whitespace
lib/ansible/modules/network/junos/junos_config.py:119:86: W291 trailing whitespace
lib/ansible/modules/network/junos/junos_config.py:120:88: W291 trailing whitespace

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

test/sanity/validate-modules/ignore.txt:618:1: A102 Remove since "lib/ansible/modules/network/junos/junos_config.py" passes "E326" test

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Jan 24, 2019

cc @Qalthos @ganeshrn @privateip
click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Jan 24, 2019

@crab86, just so you are aware we have a dedicated Working Group for network.
You can find other people interested in this in #ansible-network on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 ci_verified Changes made in this PR are causing tests to fail. docs This issue/PR relates to or includes documentation. module This issue/PR relates to a module. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_triage Needs a first human triage before being processed. networking Network category new_contributor This PR is the first contribution by a new community member. support:network This issue/PR relates to code supported by the Ansible Network Team. labels Jan 24, 2019
@ansibot
Copy link
Contributor

ansibot commented Jan 24, 2019

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

test/sanity/validate-modules/ignore.txt:618:1: A102 Remove since "lib/ansible/modules/network/junos/junos_config.py" passes "E326" test

click here for bot help

@acozine
Copy link
Contributor

acozine commented Jan 24, 2019

Thanks @crab86 for this - to make the PR pass our CI suite, you need to remove line 618 of this ignore.txt file. Removing that line will get our CI system to run the validate-modules test on the junos_config.py file, protecting us against regressions.

@acozine acozine removed the needs_triage Needs a first human triage before being processed. label Jan 24, 2019
@crab86
Update junos_config.py
c87ea63 
The current junos_config module documentation only lists "merge","override" and "replace" as update parameter choices. Looking into junos_python.py "update" is another option which is really helpful and in my opinion the most needed option.

'''
update=dict(default='merge', choices=['merge', 'override', 'replace', 'update'])
'''

+label: docsite_pr
@ansibot
Copy link
Contributor

ansibot commented Jan 25, 2019

cc @mattclay
click here for bot help

@ansibot ansibot added support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. core_review In order to be merged, this PR must follow the core review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jan 25, 2019
@samccann @crab86
Fixup Update junos_config.py
37f289d 
The current junos_config module documentation only lists "merge","override" and "replace" as update parameter choices. Looking into junos_python.py "update" is another option which is really helpful and in my opinion the most needed option.

'''
update=dict(default='merge', choices=['merge', 'override', 'replace', 'update'])
'''

Co-Authored-By: crab86 <sgesenhoff@gmail.com>
@Qalthos Qalthos merged commit 48107ac into ansible:devel Jan 30, 2019
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@samccann samccann samccann left review comments

@ganeshrn ganeshrn ganeshrn approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. module This issue/PR relates to a module. networking Network category new_contributor This PR is the first contribution by a new community member. support:core This issue/PR relates to code supported by the Ansible Engineering Team. support:network This issue/PR relates to code supported by the Ansible Network Team. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@crab86 @ansibot @acozine @ganeshrn @samccann @Qalthos