Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make na_ontap_user idempotent #51509

Merged
merged 5 commits into from
Feb 21, 2019
Merged

Make na_ontap_user idempotent #51509

merged 5 commits into from
Feb 21, 2019

Conversation

carchi8py
Copy link
Contributor

SUMMARY

na_ontap_user would attempt to change the password everytime it was rerun and give an error. If all information user information is the same ignore warning that password is the same and return ok

Fixes #44129

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME
  • na_ontap_user
ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented Jan 30, 2019

cc @amit0701 @hulquest @lmprice @lonico @ndswartz @schmots1
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. netapp storage support:certified This issue/PR relates to certified code. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Jan 30, 2019
@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Feb 5, 2019
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Feb 13, 2019
lonico
lonico approved these changes Feb 15, 2019
View reviewed changes
Copy link
Contributor

@lonico lonico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed core_review In order to be merged, this PR must follow the core review workflow. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Feb 15, 2019
beeankha
beeankha approved these changes Feb 19, 2019
View reviewed changes
Copy link
Contributor

@beeankha beeankha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally 👍

@gundalow gundalow merged commit bd8e75a into ansible:devel Feb 21, 2019
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lonico lonico lonico approved these changes

@beeankha beeankha beeankha approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. module This issue/PR relates to a module. netapp shipit This PR is ready to be merged by Core storage support:certified This issue/PR relates to certified code. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

na_ontap_user module not idempotent
6 participants
@carchi8py @ansibot @lonico @beeankha @sivel @gundalow