Yum module does not use proxy when username is not set

[1kaw]

SUMMARY

See also: #18979 (comment)

In installing remote RPM using Yum module,
Yum module uses proxy only when proxy with authentication is set in yum.conf. and proxy is not used when proxy with no authentication is set.

The code causing this bug is shown below:

ansible/lib/ansible/modules/packaging/os/yum.py

Lines 710 to 727 in b967f4d

	if my.conf.proxy:
	if my.conf.proxy_username:
	namepass = namepass + my.conf.proxy_username
	proxy_url = my.conf.proxy
	if my.conf.proxy_password:
	namepass = namepass + ":" + my.conf.proxy_password
	elif '@' in my.conf.proxy:
	namepass = my.conf.proxy.split('@')[0].split('//')[-1]
	proxy_url = my.conf.proxy.replace("{0}@".format(namepass), "")
	if namepass:
	namepass = namepass + '@'
	for item in scheme:
	os.environ[item + "_proxy"] = re.sub(
	r"(http://)",
	r"\g<1>" + namepass, proxy_url
	)
	yield

ISSUE TYPE

• Bug Report

COMPONENT NAME

Yum module

ANSIBLE VERSION

• 2.7
• devel branch

CONFIGURATION

N/A

OS / ENVIRONMENT

N/A

STEPS TO REPRODUCE

1. install and start proxy (without basic authentication)
2. write proxy=http://myproxy:8888 in yum.conf
3. try to install remote rpm using yum module

- yum:
    name: http://www.yum-repository.com/remote.rpm

EXPECTED RESULTS

yum module downloads the rpm via my proxy.

ACTUAL RESULTS

yum module does NOT use my proxy.

[ansibot]

Files identified in the description:

• lib/ansible/modules/packaging/os/yum.py

If these files are inaccurate, please update the component name section of the description or use the !component bot command.

click here for bot help

[ansibot]

cc @Akasurde @berenddeschouwer @kustodian @maxamillion @verm666
click here for bot help