Fixes #5159 file module: Don't catch SystemExit

[JensRantil]

This fixes issue #5159.

[jctanner]

@JensRantil it would be nice to include the content of "e" in the exit message.

[JensRantil]

@JensRantil it would be nice to include the content of "e" in the exit message.

@jctanner Good point. Absolutely. Is there a standard keyword for that? Will I need to translate e to a string before setting it as a parameter to module.exit_json(...)?

Also, maybe module.fail_json(...) is a better function to call?

[jctanner]

You can cast e to a string:

module.exit_json(msg="rmtree failed: %s" % str(e))

Yes, fail_json would be a better way to exit if there is a true exception.

[JensRantil]

@jctanner Fixed. Holler if you have any other corrections.

[jctanner]

@JensRantil thank you!

Tested with:

# prepatch, delete dir check
jtanner@u1304:~/issues/5159-file-directory-exception$ ansible -i inventory localhost --check -m file -a 'path=/tmp/foo state=absent'
localhost | FAILED => failed to parse: {"changed": true}
{"msg": "rmtree failed", "changed": false}

# directory owned by jtanner, remove as root
jtanner@u1304:~/issues/5159-file-directory-exception$ ansible -i inventory localhost --check -m file -a 'path=/tmp/foo state=absent'

localhost | success >> {
    "changed": true
}

# directory owned by root, delete as jtanner
jtanner@u1304:~/issues/5159-file-directory-exception$ ansible -i inventory localhost  -c local -m file -a 'path=/tmp/foo state=absent'
localhost | FAILED >> {
    "failed": true,
    "msg": "rmtree failed: [Errno 1] Operation not permitted: '/tmp/foo'"
}