New module: xfs_quota

[bushvin]

SUMMARY

This is a new module to manage XFS quota's

ISSUE TYPE

• New Module Pull Request

COMPONENT NAME

xfs_quota

ADDITIONAL INFORMATION

There was no 'easy' way to manage XFS quota's, so I wrote one.
This module allows to manage block and inode quotas for 'projects' and 'users' on XFS filesystems

[ansibot]

@AugustusKling @ColOfAbRiX @EvanK @L2G @LinusU @Mogztter @MorrisA @abulimov @adejoux @ahtik @andrew-d @azaghal @bgurney-rh @brontitall @danieljaouen @dankeder @davidobrien1985 @davixx @dermute @dirtyharrycallahan @dougluce @dsummersl @fishman @flynn1973 @gforster @giovannisciortino @goozbach @groks @haad @hryamzik @indrajitr @jasperla @jbenden @jcftang @jdauphant @jhoekx @jpdasma @jsumners @jtyr @kairoaraujo @kevensen @kyleabenson @lberruti @marvin-sinister @mator @mattjeffery @matze @mcv21 @molekuul @mpdehaan @mulby @natefoo @nibalizer @obourdon @ovcharenko @pilou- @pmarkham @pyykkis @ramooncamacho @rhaido @risaacson @ryan_sb @saito-hideki @scathatheworm @sebastiendarocha @sfromm @srvg @szinck @tacatac @tdtrask @tmshn @troy2914 @wtcross @xen0l

As a maintainer of a module in the same namespace this new module has been submitted to, your vote counts for shipits. Please review this module and add shipit if you would like to see it merged.

click here for bot help

[dagwieers]

LGTM, with various remarks.

[dagwieers]

It would be nice to have integration tests for this module, preferably using maybe a file as a filesystem (if that is at all possible).

[bushvin]

@dagwieers I would appreciate some help on the integration tests.
I've had a look at the integration test documents, and some other integration tests included in the project, but being intimidated by it, I'm not quite sure where to begin.
If you have some more 'user-friendly' examples, docs, I'd be more than happy to read through them.

I think I may have been looking at the wrong tests...
This might actually be doable... ;)

[bushvin]

There, I added integration tests.

[dagwieers]

Integration tests are looking good! Except, I would do an assert after every task.

The main reason for doing this, is that it is easier to troubleshoot if you can see the output from the task together with the failing assert.

If you don't have them together, you may need to look first in the playbook to know the order of the task, and what the output is registered as, before you can analyse why it failed. That is also why I add a name: for every assert that actually states what output we are testing against.

[dagwieers]

rebuild_merge