Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly handle unauthenticated yum proxy config #51915

Merged
merged 1 commit into from Feb 9, 2019
Merged

Properly handle unauthenticated yum proxy config #51915

merged 1 commit into from Feb 9, 2019

Conversation

maxamillion
Copy link
Contributor

SUMMARY

Properly handle the scenario where someone is using an unauthenticated proxy

Fixes #51548

Signed-off-by: Adam Miller admiller@redhat.com

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

yum

@maxamillion
Properly handle unauthenticated yum proxy config
a0d8fae 
Fixes ansible#51548

Signed-off-by: Adam Miller <admiller@redhat.com>
@ansibot
Copy link
Contributor

ansibot commented Feb 7, 2019

cc @Akasurde @berenddeschouwer @kustodian @verm666
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Feb 7, 2019
@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Feb 8, 2019
@maxamillion
Copy link
Contributor Author

rebuild_merge

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed core_review In order to be merged, this PR must follow the core review workflow. labels Feb 9, 2019
@ansibot ansibot merged commit 2721ed2 into ansible:devel Feb 9, 2019
@1kaw 1kaw mentioned this pull request Feb 9, 2019
Merged
1kaw pushed a commit to 1kaw/ansible that referenced this pull request Feb 14, 2019
@maxamillion @1kaw
Properly handle unauthenticated yum proxy config (ansible#51915)
dd97346 
Fixes ansible#51548

Signed-off-by: Adam Miller <admiller@redhat.com>
(cherry picked from commit 2721ed2)
@1kaw 1kaw mentioned this pull request Feb 14, 2019
Merged
abadger pushed a commit that referenced this pull request Feb 14, 2019
@1kaw @abadger
Backport/2.7/51548 - Properly handle unauthenticated yum proxy config (…
dc3b7ae 
…#52245)

* Properly handle unauthenticated yum proxy config (#51915)

Fixes #51548

Signed-off-by: Adam Miller <admiller@redhat.com>
(cherry picked from commit 2721ed2)

* Fix: Yum module does not use proxy when username is not set #51548 (#51994)

* add test of yum with proxy

* Properly handle unauthenticated yum proxy config

Fixes #51548

* shell executable is bash

(cherry picked from commit c2a409a)
@dagwieers dagwieers added the packaging Packaging category label Mar 3, 2019
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mkrizek mkrizek mkrizek approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. module This issue/PR relates to a module. packaging Packaging category shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Yum module does not use proxy when username is not set
4 participants
@maxamillion @ansibot @mkrizek @dagwieers