Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify na_ontap_net_port NetAppModule module format, allow for multiple ports, unit tests #52286

Merged
merged 5 commits into from
Mar 13, 2019
Merged

Modify na_ontap_net_port NetAppModule module format, allow for multiple ports, unit tests #52286

merged 5 commits into from
Mar 13, 2019

Conversation

carchi8py
Copy link
Contributor

SUMMARY

Change na_ontap_net_port to NetAppModule module format
Add ability to modify mutiple ports
add unit tests

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME
  • na_ontap_net_port
ADDITIONAL INFORMATION

carchi8py and others added 4 commits February 14, 2019 09:41
@carchi8py
Revert "changes to clusteR"
8e56b99 
This reverts commit 33ee1b71e4bc8435fb315762a871f8c4cb6c5f80.
@carchi8py
add update to netport
fe13663
@carchi8py
Revert "Revert "changes to clusteR""
320c272 
This reverts commit 8e56b99.
@carchi8py
fix docs
2fa23d7
@ansibot
Copy link
Contributor

ansibot commented Feb 14, 2019

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/storage/netapp/na_ontap_net_port.py:0:0: E309 version_added for new option (ports) should be None. Currently '2.8'

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Feb 14, 2019

cc @amit0701 @hulquest @lmprice @lonico @ndswartz @schmots1
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 ci_verified Changes made in this PR are causing tests to fail. feature This issue/PR relates to a feature request. module This issue/PR relates to a module. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_triage Needs a first human triage before being processed. netapp storage support:certified This issue/PR relates to certified code. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Feb 14, 2019
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Feb 15, 2019
lonico
lonico approved these changes Feb 15, 2019
View reviewed changes
Copy link
Contributor

@lonico lonico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. labels Feb 15, 2019
beeankha
beeankha approved these changes Feb 19, 2019
View reviewed changes
Copy link
Contributor

@beeankha beeankha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests passed, looks good to me. 👍

@gundalow
Copy link
Contributor

rebuild_merge

@gundalow gundalow merged commit 2e47e9f into ansible:devel Mar 13, 2019
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lonico lonico lonico approved these changes

@beeankha beeankha beeankha approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 feature This issue/PR relates to a feature request. module This issue/PR relates to a module. netapp shipit This PR is ready to be merged by Core storage support:certified This issue/PR relates to certified code. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@carchi8py @ansibot @gundalow @lonico @beeankha