Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VMware: Fixing VMWare Guest Disk Creation when Using Template #52676

Merged
merged 1 commit into from
Feb 25, 2019
Merged

VMware: Fixing VMWare Guest Disk Creation when Using Template #52676

merged 1 commit into from
Feb 25, 2019

Conversation

imjoseangel
Copy link
Contributor

SUMMARY

Fixes #52637

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

vmware_guest

ADDITIONAL INFORMATION
-            elif vm_obj is None:
+            elif vm_obj is None or self.params['template']:
                   # We are creating new VM or from Template
                   diskspec.fileOperation = vim.vm.device.VirtualDeviceSpec.FileOperation.create

@ansibot
Copy link
Contributor

ansibot commented Feb 20, 2019

@ansibot
Copy link
Contributor

ansibot commented Feb 20, 2019

@imjoseangel, just so you are aware we have a dedicated Working Group for vmware.
You can find other people interested in this in #ansible-vmware on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. small_patch support:community This issue/PR relates to code supported by the Ansible community. vmware VMware community labels Feb 20, 2019
@Akasurde Akasurde changed the title Fixing VMWare Guest Disk Creation when Using Template VMware: Fixing VMWare Guest Disk Creation when Using Template Feb 21, 2019
@Akasurde Akasurde removed the needs_triage Needs a first human triage before being processed. label Feb 21, 2019
@Akasurde
Copy link
Member

@Tomorrow9 Could you please review this ? Thanks.

@Akasurde Akasurde self-requested a review February 21, 2019 04:36
@Akasurde Akasurde merged commit e729ad5 into ansible:devel Feb 25, 2019
@imjoseangel imjoseangel deleted the issue/2.8/52637 branch February 25, 2019 13:59
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. small_patch support:community This issue/PR relates to code supported by the Ansible community. vmware VMware community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error Creating a Secondary Disk from Template in VMWare with vmware_guest
3 participants