VMware: Fix KeyError in vmware_host_config_manager

[mariolenz]

SUMMARY

option_manager.supportedOption may return options that aren't set which results in a KeyError

Fixes #44561

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

vmware_host_config_manager

ADDITIONAL INFORMATION

The problem is that first all options that are set are retrieved and then this list is updated with every option's type. When 'Vpx.Vpxa.config.log.level' is supported but not set, this results in a KeyError because host_facts[Vpx.Vpxa.config.log.level'] doesn't exist.

I think it is better to first get a list of all supported options and then update this list with every option's actual value.

[ansibot]

cc @Akasurde @Tomorrow9 @ckotte @dav1x @lparkes @warthog9
click here for bot help

[ansibot]

@mariolenz, just so you are aware we have a dedicated Working Group for vmware.
You can find other people interested in this in #ansible-vmware on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

[Akasurde]

@mariolenz Thanks for the PR. Could you please add a changelog fragment like this ?

[mariolenz]

@mariolenz Thanks for the PR. Could you please add a changelog fragment like this ?

I've added a changelog fragment and squashed the commit with the previous one because I didn't want to clutter your commit history. Hope it's OK now, otherwise just tell me :-)

[Akasurde]

LGTM

[Akasurde]

@pdellaert @dericcrago @Im0 @ckotte @jeking3 @Tomorrow9 Could you please review this ?

[pdellaert]

LGTM

[Akasurde]

@mariolenz Thanks for the contribution. @pdellaert Thanks for the review.