replace uses of sort_json_policy_dict with compare_policies #52943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…compatible with Python 3 and remove sort_json_policy_dict from the AWS guidelines since it only works on Python 2
|
@s-hertel, just so you are aware we have a dedicated Working Group for aws. |
ansibot
added
affects_2.8
samdoran
removed
the
needs_triage
samdoran
reviewed
Feb 27, 2019
| @@ -292,19 +292,15 @@ def run(ecr, params, verbosity): | |||
|
|
|||
| elif policy_text is not None: | |||
| try: | |||
| policy = sort_json_policy_dict(policy) | |||
There was a problem hiding this comment.
Minor thing, not a blocker: Since this line is gone, the returned policy is no longer sorted but only when verbosity > 2. I'm not sure how much that matters.
There was a problem hiding this comment.
Thanks, missed that! I added a commit to sort policy lists only containing string types so it works on python 3.
samdoran
approved these changes
Feb 27, 2019
|
You are a scholar and a gentleperson. This works for me. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Use compare_policies since it is compatible with Python 3
remove sort_json_policy_dict from the AWS guidelines since it only works consistently on Python 2
Fixes #43029
ISSUE TYPE