Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify the correct variable when setting available hashing algorithms #52994

Merged
merged 2 commits into from Feb 28, 2019
Merged

Modify the correct variable when setting available hashing algorithms #52994

merged 2 commits into from Feb 28, 2019

Conversation

samdoran
Copy link
Contributor

SUMMARY

We were modifying the incorrect variable when md5 was unavailable. That variable is a tuple which has no .pop() method. The intended variable to be modified was AVAILABLE_HASH_ALGORITHMS which is a dictionary and has a .pop() method.

Fixes #51355
Replaces #51357
Reverts c459f04

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

lib/ansible/module_utils/basic.py

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Feb 26, 2019
@ansibot
Copy link
Contributor

ansibot commented Feb 26, 2019

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/cloud/kubevirt/kubevirt_template.py:0:0: E325 Argument 'resource_definition' in argument_spec defines type as <function list_dict_str at 0x7f73d9b32c80> but documentation defines type as 'str'

click here for bot help

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Feb 26, 2019
@bcoca bcoca removed the needs_triage Needs a first human triage before being processed. label Feb 26, 2019
@samdoran samdoran added needs_triage Needs a first human triage before being processed. and removed needs_triage Needs a first human triage before being processed. labels Feb 26, 2019
@samdoran samdoran merged commit 23a6b88 into ansible:devel Feb 28, 2019
@samdoran samdoran deleted the issue/51355-fips-md5 branch February 28, 2019 12:32
samdoran added a commit to samdoran/ansible that referenced this pull request Feb 28, 2019
@samdoran
[stable-2.7] Modify the correct variable when setting available hashi…
07bf732 
…ng algorithms (ansible#52994)

* Revert "use list instead of tuple and remove md5 on ValueError (ansible#51357)" c459f04.
* Modify the correct variable when determining available hashing algorithms.
(cherry picked from commit 23a6b88)

Co-authored-by: Sam Doran <sdoran@redhat.com>
@samdoran samdoran mentioned this pull request Feb 28, 2019
Merged
abadger pushed a commit that referenced this pull request Mar 2, 2019
@samdoran @abadger
[stable-2.7] Modify the correct variable when setting available hashi…
d44f80c 
…ng algorithms (#52994)

* Revert "use list instead of tuple and remove md5 on ValueError (#51357)" c459f04.
* Modify the correct variable when determining available hashing algorithms.
(cherry picked from commit 23a6b88)

Co-authored-by: Sam Doran <sdoran@redhat.com>
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@abadger abadger Awaiting requested review from abadger

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

module_utils/basic.py fails with FIPS 140-2 enabled systems
3 participants
@samdoran @ansibot @bcoca