Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable-2.7] Modify the correct variable when setting available hashing algorithms (#52994) #53135

Merged
merged 1 commit into from
Mar 2, 2019
Merged

[stable-2.7] Modify the correct variable when setting available hashing algorithms (#52994) #53135

merged 1 commit into from
Mar 2, 2019

Conversation

samdoran
Copy link
Contributor

SUMMARY

Backport of #52994 for Ansible 2.7

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

lib/ansible/module_utils/basic.py

@samdoran
[stable-2.7] Modify the correct variable when setting available hashi…
07bf732 
…ng algorithms (ansible#52994)

* Revert "use list instead of tuple and remove md5 on ValueError (ansible#51357)" c459f04.
* Modify the correct variable when determining available hashing algorithms.
(cherry picked from commit 23a6b88)

Co-authored-by: Sam Doran <sdoran@redhat.com>
@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Feb 28, 2019
@abadger
Copy link
Contributor

abadger commented Mar 1, 2019

I rekicked shippable to make sure that the test failure is transient.

@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Mar 1, 2019
@abadger abadger merged commit d44f80c into ansible:stable-2.7 Mar 2, 2019
@abadger
Copy link
Contributor

abadger commented Mar 2, 2019

Merged for the 2.7.9 release.

@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Mar 5, 2019
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.7 This issue/PR affects Ansible v2.7 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@samdoran @abadger @sivel @ansibot