Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add hcloud server module #53062

Merged
merged 12 commits into from
Mar 5, 2019
Merged

Add hcloud server module #53062

merged 12 commits into from
Mar 5, 2019

Conversation

LKaemmerling
Copy link
Contributor

SUMMARY

As follow up from #52553 we would like to contribute the first module for our Hetzner Cloud: hcloud_server

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

hcloud_server

ADDITIONAL INFORMATION

@resmo resmo self-requested a review February 27, 2019 13:47
@ansibot
Copy link
Contributor

ansibot commented Feb 27, 2019

cc @mattclay
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 cloud core_review In order to be merged, this PR must follow the core review workflow. hcloud module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Feb 27, 2019
resmo
resmo suggested changes Feb 27, 2019
View reviewed changes
lib/ansible/module_utils/hcloud.py Outdated Show resolved Hide resolved
lib/ansible/module_utils/hcloud.py Outdated Show resolved Hide resolved
lib/ansible/module_utils/hcloud.py Show resolved Hide resolved
lib/ansible/modules/cloud/hcloud/hcloud_server.py Outdated Show resolved Hide resolved
lib/ansible/modules/cloud/hcloud/hcloud_server.py Outdated Show resolved Hide resolved
lib/ansible/modules/cloud/hcloud/hcloud_server.py Show resolved Hide resolved
lib/ansible/modules/cloud/hcloud/hcloud_server.py Outdated Show resolved Hide resolved
lib/ansible/modules/cloud/hcloud/hcloud_server.py Outdated Show resolved Hide resolved
lib/ansible/modules/cloud/hcloud/hcloud_server.py Outdated Show resolved Hide resolved
lib/ansible/modules/cloud/hcloud/hcloud_server.py Outdated Show resolved Hide resolved
@resmo resmo self-requested a review February 27, 2019 16:37
@resmo resmo self-requested a review February 27, 2019 16:38
@LKaemmerling LKaemmerling mentioned this pull request Feb 28, 2019
Closed
@decentral1se
Copy link
Contributor

decentral1se commented Feb 28, 2019 •
edited

Closes #52813.

gandhiano
gandhiano approved these changes Feb 28, 2019
View reviewed changes
Copy link

@gandhiano gandhiano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Properly designed and addressing the requirements of #52813 for provisioning and managing hetzner cloud hosts.

@decentral1se decentral1se mentioned this pull request Feb 28, 2019
Closed
@gandhiano gandhiano mentioned this pull request Feb 28, 2019
Open
@decentral1se
Copy link
Contributor

Opening ansible/molecule#1791 to cover on Molecule side 👍

@ansibot ansibot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Mar 1, 2019
@dagwieers dagwieers mentioned this pull request Mar 4, 2019
Closed
dagwieers
dagwieers approved these changes Mar 4, 2019
View reviewed changes
Copy link
Contributor

@dagwieers dagwieers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Mar 4, 2019
@resmo
Copy link
Contributor

resmo commented Mar 5, 2019

shipit

@resmo resmo merged commit 66beeaf into ansible:devel Mar 5, 2019
@resmo
Copy link
Contributor

resmo commented Mar 5, 2019

Thanks!

@LKaemmerling LKaemmerling deleted the add-hcloud-server-module branch March 5, 2019 06:32
@gundalow
Copy link
Contributor

gundalow commented Mar 5, 2019

Great to see this merged, thanks everybody for the reviews!

@bcoca bcoca removed needs_triage Needs a first human triage before being processed. labels Mar 5, 2019
This was referenced Mar 7, 2019
Merged
Merged
@decentral1se
Copy link
Contributor

Small docs fix over at #53466 👍

This was referenced Mar 8, 2019
Merged
Merged
Closed
@ghost ghost mentioned this pull request Mar 13, 2019
Merged
This was referenced Mar 15, 2019
Merged
Merged
Merged
Merged
Merged
@decentral1se decentral1se mentioned this pull request Apr 24, 2019
Merged
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@resmo resmo resmo approved these changes

@dagwieers dagwieers dagwieers approved these changes

@gundalow gundalow gundalow left review comments

@samccann samccann samccann left review comments

@decentral1se decentral1se decentral1se approved these changes

@gandhiano gandhiano gandhiano approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 cloud core_review In order to be merged, this PR must follow the core review workflow. hcloud module This issue/PR relates to a module. new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@LKaemmerling @ansibot @decentral1se @resmo @gundalow @dagwieers @gandhiano @samccann @bcoca