Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ios_logging: fix idempotence errors #53109

Merged
merged 3 commits into from
Mar 7, 2019
Merged

ios_logging: fix idempotence errors #53109

merged 3 commits into from
Mar 7, 2019

Conversation

hexdump0x0200
Copy link
Contributor

@hexdump0x0200 hexdump0x0200 commented Feb 28, 2019 •
edited

SUMMARY

Fixes #53226
Fixes #53227

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ios_logging

@hexdump0x0200
ios_logging: fix the error checking the existence of "host" destinati…
e566c5f 
…ons (IOS 12)

In the "have" list, records of type "host" do not contain the key "size",
although in the list "want" it is always there. Because of this, the module
assumes that the "host" type destinations is not configured and does it again.
This does not change the configuration on the device, but is redundant and
the status of the task will always be "changed". This patch fixes it.
@ansibot
Copy link
Contributor

ansibot commented Feb 28, 2019

cc @NilashishC @Qalthos @ganeshrn @gdpak @justjais @rcarrillocruz @trishnaguha
click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Feb 28, 2019

@hexdump0x0200, just so you are aware we have a dedicated Working Group for network.
You can find other people interested in this in #ansible-network on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. cisco Cisco technologies core_review In order to be merged, this PR must follow the core review workflow. ios Cisco IOS community module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category new_contributor This PR is the first contribution by a new community member. small_patch support:core This issue/PR relates to code supported by the Ansible Engineering Team. support:network This issue/PR relates to code supported by the Ansible Network Team. test This PR relates to tests. labels Feb 28, 2019
@hexdump0x0200 hexdump0x0200 changed the title ios_logging: fix the error checking the existence of "host" destinati… ios_logging: fix idempotence errors Mar 3, 2019
@hexdump0x0200
Copy link
Contributor Author

bot_status

@ansibot
Copy link
Contributor

ansibot commented Mar 4, 2019

Components

lib/ansible/modules/network/ios/ios_logging.py
support: network
maintainers: rcarrillocruz trishnaguha

test/units/modules/network/ios/fixtures/ios_logging_config.cfg
support: core
maintainers: NilashishC Qalthos ganeshrn gdpak justjais rcarrillocruz trishnaguha

test/units/modules/network/ios/fixtures/ios_logging_config_ios12.cfg
support: core
maintainers: NilashishC Qalthos ganeshrn gdpak justjais rcarrillocruz trishnaguha

test/units/modules/network/ios/test_ios_logging.py
support: core
maintainers: NilashishC Qalthos ganeshrn gdpak justjais rcarrillocruz trishnaguha

Metadata

waiting_on: ansible
changes_requested_by: null
needs_info: False
needs_revision: False
needs_rebase: False
merge_commits: []
too many files or commits: False
mergeable_state: clean
shippable_status: success
maintainer_shipits (module maintainers): 0
community_shipits (namespace maintainers): 0
ansible_shipits (core team members): 0
shipit_actors (maintainer or core team member): []
shipit_actors_other: []
automerge: automerge shipit test failed

click here for bot help

@hexdump0x0200
Copy link
Contributor Author

ready_for_review

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. labels Mar 7, 2019
@hexdump0x0200
Copy link
Contributor Author

ready_for_review

@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Mar 7, 2019
@NilashishC NilashishC merged commit 4d407d1 into ansible:devel Mar 7, 2019
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@NilashishC NilashishC NilashishC approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. cisco Cisco technologies core_review In order to be merged, this PR must follow the core review workflow. ios Cisco IOS community module This issue/PR relates to a module. networking Network category new_contributor This PR is the first contribution by a new community member. support:core This issue/PR relates to code supported by the Ansible Engineering Team. support:network This issue/PR relates to code supported by the Ansible Network Team. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
3 participants
@hexdump0x0200 @ansibot @NilashishC