Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Examples with bad options #53279

Merged
merged 8 commits into from
Mar 7, 2019
Merged

Fix Examples with bad options #53279

merged 8 commits into from
Mar 7, 2019

Conversation

carchi8py
Copy link
Contributor

SUMMARY

Some modules were using options were using old names that have since been changed.

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME
  • na_ontap_cg_snapshot.py
  • na_ontap_cifs_acl.py
  • na_ontap_cifs_server.py
  • na_ontap_igroup_initiator.py
  • na_ontap_ntp.py
ADDITIONAL INFORMATION

@carchi8py
Revert "changes to clusteR"
cff1a6f 
This reverts commit 33ee1b71e4bc8435fb315762a871f8c4cb6c5f80.
@carchi8py
Revert "Revert "changes to clusteR""
ee09d03 
This reverts commit f1104a3.
@carchi8py
Revert "changes to clusteR"
06475ef 
This reverts commit 33ee1b71e4bc8435fb315762a871f8c4cb6c5f80.
@carchi8py
Revert "Revert "changes to clusteR""
1e66ee7 
This reverts commit f1104a3.
@carchi8py
documentation changes
ea60f5f
@carchi8py
Revert "documentation changes"
855a0fb 
This reverts commit 02c369d0414fdff492d90865c903bdade3174261.
@carchi8py
Doc updates
93f7fbc
@ansibot
Copy link
Contributor

ansibot commented Mar 4, 2019

cc @amit0701 @hulquest @lmprice @lonico @ndswartz @schmots1
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 committer_review In order to be merged, this PR must follow the certified review workflow. docs This issue/PR relates to or includes documentation. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. netapp owner_pr This PR is made by the module's maintainer. storage support:certified This issue/PR relates to certified code. support:community This issue/PR relates to code supported by the Ansible community. labels Mar 4, 2019
lonico
lonico approved these changes Mar 5, 2019
View reviewed changes
Copy link
Contributor

@lonico lonico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed committer_review In order to be merged, this PR must follow the certified review workflow. needs_triage Needs a first human triage before being processed. labels Mar 5, 2019
samccann
samccann reviewed Mar 6, 2019
View reviewed changes
Copy link
Contributor

@samccann samccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also change -

ansible/lib/ansible/modules/storage/netapp/na_ontap_cifs_server.py

Line 74 in 93f7fbc

specified in 'cifs_server_name' exists in the Active Directory, it
so the description doesn't reference 'cifs_server_name' anymore?

@JohnLieske
Copy link

Can you also change -

ansible/lib/ansible/modules/storage/netapp/na_ontap_cifs_server.py

Line 74 in 93f7fbc

   specified in 'cifs_server_name' exists in the Active Directory, it

so the description doesn't reference 'cifs_server_name' anymore?

@carchi8py ^

@carchi8py
Copy link
Contributor Author

I've made the change internally this morning, waiting for it to finish going through our internal process and then will push out the fix.

@samccann samccann merged commit 106c788 into ansible:devel Mar 7, 2019
@samccann
Copy link
Contributor

samccann commented Mar 7, 2019

Thanks @carchi8py for the ansible doc update.

@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lonico lonico lonico approved these changes

@samccann samccann samccann approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 docs This issue/PR relates to or includes documentation. module This issue/PR relates to a module. netapp owner_pr This PR is made by the module's maintainer. shipit This PR is ready to be merged by Core storage support:certified This issue/PR relates to certified code. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@carchi8py @ansibot @JohnLieske @samccann @lonico