Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Examples with bad options #53279

Merged
merged 8 commits into from
Mar 7, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/ansible/modules/storage/netapp/na_ontap_cg_snapshot.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#!/usr/bin/python

# (c) 2018, NetApp, Inc
# (c) 2018-2019, NetApp, Inc
# GNU General Public License v3.0+ (see COPYING or https://www.gnu.org/licenses/gpl-3.0.txt)

from __future__ import absolute_import, division, print_function
Expand Down Expand Up @@ -53,7 +53,7 @@
state: present
vserver: vserver_name
snapshot: snapshot name
volume: vol_name
volumes: vol_name
username: "{{ netapp username }}"
password: "{{ netapp password }}"
hostname: "{{ netapp hostname }}"
Expand Down
7 changes: 5 additions & 2 deletions lib/ansible/modules/storage/netapp/na_ontap_cifs_acl.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#!/usr/bin/python

# (c) 2018, NetApp, Inc
# (c) 2018-2019, NetApp, Inc
# GNU General Public License v3.0+ (see COPYING or https://www.gnu.org/licenses/gpl-3.0.txt)

from __future__ import absolute_import, division, print_function
Expand Down Expand Up @@ -40,7 +40,7 @@
description:
- "The user or group name for which the permissions are listed."
required: true
short_description: "NetApp ONTAP manage cifs-share-access-control"
short_description: NetApp ONTAP manage cifs-share-access-control
version_added: "2.6"

'''
Expand All @@ -52,14 +52,17 @@
share_name: cifsShareName
user_or_group: Everyone
permission: read
vserver: "{{ netapp_vserver }}"
hostname: "{{ netapp_hostname }}"
username: "{{ netapp_username }}"
password: "{{ netapp_password }}"
- name: Modify CIFS share acl permission
na_ontap_cifs_acl:
state: present
share_name: cifsShareName
user_or_group: Everyone
permission: change
vserver: "{{ netapp_vserver }}"
hostname: "{{ netapp_hostname }}"
username: "{{ netapp_username }}"
password: "{{ netapp_password }}"
Expand Down
6 changes: 3 additions & 3 deletions lib/ansible/modules/storage/netapp/na_ontap_cifs_server.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#!/usr/bin/python
""" this is cifs_server module

(c) 2018, NetApp, Inc
(c) 2018-2019, NetApp, Inc
# GNU General Public License v3.0+ (see COPYING or https://www.gnu.org/licenses/gpl-3.0.txt)
"""

Expand Down Expand Up @@ -71,7 +71,7 @@
type: bool
description:
- If this is set and a machine account with the same name as
specified in 'cifs_server_name' exists in the Active Directory, it
specified in 'name' exists in the Active Directory, it
will be overwritten and reused.
version_added: '2.7'

Expand All @@ -94,7 +94,7 @@
- name: Delete cifs_server
na_ontap_cifs_server:
state: absent
cifs_server_name: data2
name: data2
vserver: svm1
hostname: "{{ netapp_hostname }}"
username: "{{ netapp_username }}"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@
EXAMPLES = '''
- name: Add initiators to an igroup
na_ontap_igroup_initiator:
names: abc.test:def.com, def.test:efg.com
names: abc.test:def.com,def.test:efg.com
initiator_group: test_group
vserver: ansibleVServer
hostname: "{{ netapp_hostname }}"
Expand All @@ -65,7 +65,7 @@
- name: Remove an initiator from an igroup
na_ontap_igroup_initiator:
state: absent
name: abc.test:def.com
names: abc.test:def.com
initiator_group: test_group
vserver: ansibleVServer
hostname: "{{ netapp_hostname }}"
Expand Down
4 changes: 3 additions & 1 deletion lib/ansible/modules/storage/netapp/na_ontap_ntp.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#!/usr/bin/python

# (c) 2018, NetApp, Inc
# (c) 2018-2019, NetApp, Inc
# GNU General Public License v3.0+ (see COPYING or https://www.gnu.org/licenses/gpl-3.0.txt)

from __future__ import absolute_import, division, print_function
Expand Down Expand Up @@ -43,12 +43,14 @@
na_ontap_ntp:
state: present
version: auto
server_name: "{{ server_name }}"
hostname: "{{ netapp_hostname }}"
username: "{{ netapp_username }}"
password: "{{ netapp_password }}"
- name: Delete NTP server
na_ontap_ntp:
state: absent
server_name: "{{ server_name }}"
hostname: "{{ netapp_hostname }}"
username: "{{ netapp_username }}"
password: "{{ netapp_password }}"
Expand Down