Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix azure_rm.py not showing nic info for vmss #53496

Merged
merged 2 commits into from
Mar 20, 2019
Merged

fix azure_rm.py not showing nic info for vmss #53496

merged 2 commits into from
Mar 20, 2019

Conversation

yungezz
Copy link
Contributor

@yungezz yungezz commented Mar 8, 2019

SUMMARY

fix issue #51944, in vmss nic output, there's no type, so nic model was filtered out. fix it.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION

@yungezz yungezz requested a review from nitzmahone March 8, 2019 02:19
@yungezz yungezz mentioned this pull request Mar 8, 2019
Closed
@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. labels Mar 8, 2019
@yungezz
Copy link
Contributor Author

yungezz commented Mar 8, 2019

ready_for_review

@yungezz
Copy link
Contributor Author

yungezz commented Mar 18, 2019

customer verified the PR in issue #51944

@Fred-sun
Copy link
Contributor

@nitzmahone Please help review and push this PR move forward when you're available! Thanks!

@Fred-sun
Copy link
Contributor

+azure label

@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Mar 19, 2019
@nitzmahone nitzmahone merged commit 710b05f into ansible:devel Mar 20, 2019
@mkrizek mkrizek removed needs_triage Needs a first human triage before being processed. labels Mar 21, 2019
yungezz added a commit to VSChina/ansible that referenced this pull request Mar 26, 2019
@yungezz
fix azure_rm.py not showing nic info for vmss (ansible#53496)
ae6673b 
* fix vmss nic

* resolve comments

(cherry picked from commit 710b05f)
@yungezz yungezz mentioned this pull request Mar 26, 2019
Merged
abadger pushed a commit that referenced this pull request Apr 1, 2019
@yungezz @abadger
Backport/2.7/53496: fix azure_rm.py not showing nic info for vmss #53496
e31620e 
 (#54379)

* fix azure_rm.py not showing nic info for vmss (#53496)

* fix vmss nic

* resolve comments

(cherry picked from commit 710b05f)

* add changelog
@yungezz yungezz deleted the yungez-inventory-vmss-nic branch April 9, 2019 02:12
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nitzmahone nitzmahone nitzmahone approved these changes

@zikalino zikalino zikalino approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@yungezz @Fred-sun @nitzmahone @zikalino @mkrizek @ansibot