-
Notifications
You must be signed in to change notification settings - Fork 23.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix azure_rm.py not showing nic info for vmss #53496
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
affects_2.8
This issue/PR affects Ansible v2.8
bug
This issue/PR relates to a bug.
community_review
In order to be merged, this PR must follow the community review workflow.
needs_triage
Needs a first human triage before being processed.
support:community
This issue/PR relates to code supported by the Ansible community.
labels
Mar 8, 2019
ready_for_review |
zikalino
reviewed
Mar 8, 2019
zikalino
approved these changes
Mar 8, 2019
customer verified the PR in issue #51944 |
@nitzmahone Please help review and push this PR move forward when you're available! Thanks! |
+azure label |
ansibot
added
the
stale_ci
This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested.
label
Mar 19, 2019
nitzmahone
approved these changes
Mar 20, 2019
yungezz
added a commit
to VSChina/ansible
that referenced
this pull request
Mar 26, 2019
* fix vmss nic * resolve comments (cherry picked from commit 710b05f)
abadger
pushed a commit
that referenced
this pull request
Apr 1, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
affects_2.8
This issue/PR affects Ansible v2.8
bug
This issue/PR relates to a bug.
community_review
In order to be merged, this PR must follow the community review workflow.
stale_ci
This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested.
support:community
This issue/PR relates to code supported by the Ansible community.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
fix issue #51944, in vmss nic output, there's no type, so nic model was filtered out. fix it.
ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION