Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

meraki - Unchanged requests now return the original data #53576

Merged
merged 7 commits into from
May 17, 2019
Merged

meraki - Unchanged requests now return the original data #53576

merged 7 commits into from
May 17, 2019

Conversation

kbreit
Copy link
Contributor

@kbreit kbreit commented Mar 9, 2019 •
edited

SUMMARY

Fixes #53575

Unchanged data now returns the existing information so it's idempotent to the end user.

Modules Tested Via Integration Tests
  • meraki_admin
  • meraki_config_template
  • meraki_content_filtering
  • meraki_device
  • meraki_mr_l3_firewall
  • meraki_mx_l3_firewall
  • meraki_network
  • meraki_organization
  • meraki_snmp
  • meraki_ssid
  • meraki_static_route
  • meraki_switchport
  • meraki_syslog
  • meraki_vlan
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

meraki

@kbreit kbreit changed the title Unchanged requests now return the original data meraki - Unchanged requests now return the original data Mar 9, 2019
@ansibot
Copy link
Contributor

ansibot commented Mar 9, 2019

cc @dagwieers
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. cisco Cisco technologies community_review In order to be merged, this PR must follow the community review workflow. meraki Cisco Meraki community module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category owner_pr This PR is made by the module's maintainer. support:community This issue/PR relates to code supported by the Ansible community. labels Mar 9, 2019
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Mar 18, 2019
@ansibot ansibot removed owner_pr This PR is made by the module's maintainer. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Mar 27, 2019
@kbreit kbreit changed the title meraki - Unchanged requests now return the original data [WIP] meraki - Unchanged requests now return the original data Mar 29, 2019
@ansibot ansibot added WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html labels Mar 29, 2019
@kbreit kbreit mentioned this pull request Apr 3, 2019
Closed
@kbreit kbreit force-pushed the meraki/always_return_data branch from dcca5dc to 5f11c1a Compare April 3, 2019 14:54
@ansibot ansibot removed the needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html label Apr 3, 2019
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Apr 11, 2019
@kbreit kbreit changed the title [WIP] meraki - Unchanged requests now return the original data meraki - Unchanged requests now return the original data Apr 18, 2019
@ansibot ansibot added test This PR relates to tests. and removed WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Apr 18, 2019
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Apr 26, 2019
@ansibot ansibot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html and removed community_review In order to be merged, this PR must follow the community review workflow. labels May 4, 2019
@ansibot ansibot added the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label May 4, 2019
@kbreit kbreit mentioned this pull request May 9, 2019
Closed
@kbreit kbreit force-pushed the meraki/always_return_data branch from 9a71e78 to 144cbe0 Compare May 13, 2019 01:34
@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels May 13, 2019
@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label May 15, 2019
@kbreit
Copy link
Contributor Author

kbreit commented May 16, 2019

This PR depends on #54275 to pass integration tests.

@ansibot
Copy link
Contributor

ansibot commented May 16, 2019

@kbreit this PR contains the following merge commits:

Please rebase your branch to remove these commits.

click here for bot help

@ansibot ansibot added merge_commit This PR contains at least one merge commit. Please resolve! needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html and removed community_review In order to be merged, this PR must follow the community review workflow. labels May 16, 2019
@kbreit kbreit force-pushed the meraki/always_return_data branch from 0245cf0 to 3a72450 Compare May 16, 2019 18:23
@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed merge_commit This PR contains at least one merge commit. Please resolve! needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html labels May 16, 2019
@trishnaguha trishnaguha merged commit 2a187f3 into ansible:devel May 17, 2019
@kbreit kbreit deleted the meraki/always_return_data branch May 17, 2019 03:17
@ansible ansible locked and limited conversation to collaborators Aug 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@trishnaguha trishnaguha trishnaguha approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. cisco Cisco technologies community_review In order to be merged, this PR must follow the community review workflow. meraki Cisco Meraki community module This issue/PR relates to a module. networking Network category support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Meraki modules do not return information when not changed
3 participants
@kbreit @ansibot @trishnaguha