Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows - Fix issues with glob like path chars - 2.6 #53845

Merged
merged 7 commits into from
Mar 18, 2019
Merged

Windows - Fix issues with glob like path chars - 2.6 #53845

merged 7 commits into from
Mar 18, 2019

Conversation

jborean93
Copy link
Contributor

@jborean93 jborean93 commented Mar 15, 2019 •
edited

SUMMARY

Backport of #53827
Backport of #53828
Backport of #53829
Backport of #53830
Backport of #53831
Backport of #53835

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

win_acl
win_acl_inheritance
win_owner
win_slurp
win_tempfile

This was referenced Mar 15, 2019
Merged
Merged
Merged
Merged
Merged
@ansibot
Copy link
Contributor

ansibot commented Mar 15, 2019

cc @dagwieers @if-meaton @jhawkesworth @nitzmahone @schwartzmx @trondhindenes
click here for bot help

@ansibot ansibot added affects_2.6 This issue/PR affects Ansible v2.6 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. windows Windows community labels Mar 15, 2019
@ansibot
Copy link
Contributor

ansibot commented Mar 15, 2019

The test ansible-test sanity --test integration-aliases [explain] failed with 1 error:

test/integration/targets/win_acl/aliases:0:0: missing alias `shippable/windows/group[1-4]` or `unsupported`

click here for bot help

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Mar 15, 2019
@jborean93 jborean93 mentioned this pull request Mar 15, 2019
Merged
@jborean93
Copy link
Contributor Author

Tests will fail until #53843 is merged.

@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. core_review In order to be merged, this PR must follow the core review workflow. labels Mar 15, 2019
@jborean93
win_tempfile - return absolute path on created temp file (ansible#53827)
b04f34f 
* win_tempfile - return absolute path on created temp file

* Fix tests for CI

(cherry picked from commit 4f9de45)
@jborean93
win_acl - fix glob file paths (ansible#53828)
7706127 
(cherry picked from commit aba6f5f)
@jborean93
win_acl_inheritance - fix glob like paths (ansible#53829)
2469eef 
(cherry picked from commit 3cfa71b)
@jborean93
win_owner - fix glob like paths (ansible#53830)
d8ccfe8 
* win_owner - fix glob like paths

* Fix issues on older PS versions

(cherry picked from commit d063cef)
@jborean93
win_slurp - fix glob like paths (ansible#53831)
289493e 
(cherry picked from commit d00418c)
@jborean93
windows - Fix module utils with glob paths (ansible#53835)
5e01868 
* windows - Fix module utils with glob paths

* fix link util tests when using DOS 8.3 paths

(cherry picked from commit 980ca56)
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Mar 16, 2019
@abadger abadger merged commit 0429b10 into ansible:stable-2.6 Mar 18, 2019
@abadger
Copy link
Contributor

abadger commented Mar 18, 2019

Merged for 2.6.16

@jborean93 jborean93 deleted the win-paths-2.6 branch March 18, 2019 21:40
@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Mar 19, 2019
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.6 This issue/PR affects Ansible v2.6 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. windows Windows community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jborean93 @ansibot @abadger @sivel