Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paramiko might not come standard everywhere #54486

Merged
merged 2 commits into from
Apr 2, 2019

Conversation

abadger
Copy link
Contributor

@abadger abadger commented Mar 27, 2019

There is a platform where paramiko isn't shipped but a special version
of paramiko just for our use is shipped. This code imports paramiko
from that location.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

various networking code

@Qalthos @privateip

There is a platform where paramiko isn't shipped but a special version
of paramiko just for our use is shipped.  This code imports paramiko
from that location.
@ansibot
Copy link
Contributor

ansibot commented Mar 27, 2019

@abadger, just so you are aware we have a dedicated Working Group for network.
You can find other people interested in this in #ansible-network on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. cisco Cisco technologies core_review In order to be merged, this PR must follow the core review workflow. deprecated This issue/PR relates to a deprecated module. ios Cisco IOS community iosxr Cisco IOSXR community module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category nxos Cisco NXOS community support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. support:network This issue/PR relates to code supported by the Ansible Network Team. labels Mar 27, 2019
Copy link
Contributor

@jamescassell jamescassell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

@Qalthos Qalthos self-requested a review March 28, 2019 16:00
@abadger
Copy link
Contributor Author

abadger commented Apr 1, 2019

nitzmahone had a look at this and okayed it earlier on slack.

@Qalthos did you want to have a look? I need to merge this tomorrow as it blocks the alpha release.

@abadger abadger added the P2 Priority 2 - Issue Blocks Release label Apr 1, 2019
@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Apr 2, 2019
@abadger abadger merged commit b03c16f into ansible:devel Apr 2, 2019
@abadger
Copy link
Contributor Author

abadger commented Apr 2, 2019

@Qalthos Thanks!

@abadger abadger deleted the special-paramiko branch April 2, 2019 17:06
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. cisco Cisco technologies core_review In order to be merged, this PR must follow the core review workflow. deprecated This issue/PR relates to a deprecated module. ios Cisco IOS community iosxr Cisco IOSXR community module This issue/PR relates to a module. networking Network category nxos Cisco NXOS community P2 Priority 2 - Issue Blocks Release support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. support:network This issue/PR relates to code supported by the Ansible Network Team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants