Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ec2] Use user_data if specified #54494

Merged
merged 2 commits into from
Apr 9, 2019
Merged

[ec2] Use user_data if specified #54494

merged 2 commits into from
Apr 9, 2019

Conversation

s-hertel
Copy link
Contributor

SUMMARY

User data shouldn't become the string 'None'

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ec2.py

@ansibot
Copy link
Contributor

ansibot commented Mar 28, 2019

cc @lwade @tgerla
click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Mar 28, 2019

@s-hertel, just so you are aware we have a dedicated Working Group for aws.
You can find other people interested in this in #ansible-aws on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 aws bug This issue/PR relates to a bug. cloud core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. small_patch support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Mar 28, 2019
@ansibot ansibot added support:community This issue/PR relates to code supported by the Ansible community. and removed small_patch labels Mar 28, 2019
@Akasurde Akasurde removed the needs_triage Needs a first human triage before being processed. label Mar 28, 2019
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Apr 5, 2019
@s-hertel
Copy link
Contributor Author

s-hertel commented Apr 9, 2019

cc @jillr @goneri

@goneri
Copy link
Contributor

goneri commented Apr 9, 2019

shipit

@s-hertel s-hertel merged commit ba8b5ec into ansible:devel Apr 9, 2019
@s-hertel
Copy link
Contributor Author

s-hertel commented Apr 9, 2019

Thanks for the reviews!

@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jillr jillr jillr approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 aws bug This issue/PR relates to a bug. cloud core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@s-hertel @ansibot @goneri @jillr @Akasurde