fix: kinesis stream tag deletion #54537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tags.keys() returns a list of the keys, sure. But in Python 3 it's a "dict_keys" class, and BOTO is expecting a list. So let's make this work in Python 3. list(tags) returns a list of the keys in Python 2 and Python3. That seems to be what we want.
|
@Tyler-2, just so you are aware we have a dedicated Working Group for aws. |
ansibot
added
affects_2.8
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
tags.keys() returns a list of the keys, sure. But in Python 3 it's a
"dict_keys" class, and BOTO is expecting a list. So let's make this work
in Python 3 and 2.
list(tags) returns a list of the keys in Python 2 and Python3. That
seems to be what we want.
Fixes #54534
ISSUE TYPE
COMPONENT NAME
kinesis_stream
ADDITIONAL INFORMATION